Fix matrix-free deprecation warnings #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
reviewed
Jun 19, 2021
| @@ -721,10 +721,18 @@ namespace aspect | |||
|
|
|||
| velocity.reinit (cell); | |||
| velocity.read_dof_values (src.block(0)); | |||
| #if DEAL_II_VERSION_GTE(10,0,0) | |||
| velocity.evaluate (EvaluationFlags::gradients); | |||
There was a problem hiding this comment.
Is this new in 10 or already in 9.3?
There was a problem hiding this comment.
The EvaluationFlags is in 9.3.
Change to DEAL_II_VERSION_GTE(9.3.0)?
There was a problem hiding this comment.
Yes, exactly. Because starting with 9.3 we can and should use the new method.
|
Fixes #4068 |
|
/rebuild |
zjiaqi2018
force-pushed
the
fix_deprecation_warnings
branch
from
72d3e22
to
0f58b1b
Compare
gassmoeller
approved these changes
Jun 20, 2021
|
Just waiting for the tester (github actions required approval, because it considers you a first time contributor). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix matrix-free deprecation warnings, and it passed the test nsinker_gmg_idr. @tjhei