New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gravitational constant #4140
Conversation
Updated the gravitational constant to match the recommended value from CODATA. The published value (with standard error in parenthesis) and the reference were added to the comments. This change aids gravity comparisons of benchmarks with published studies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love us to be able to run simulations where this is the limiting factor on the accuracy of results :-)
/rebuild |
Well, it does matter for a few tests, apparently. 😉 |
It turns out that a number of tests are apparently sensitive enough to actually fail now:
Would you mind updating the test outputs? |
I'll start working on these |
The above commits should cover all the files from the failed tests |
Let's see what the tester says. I only spot checked, but is your sense also that the changes are marginal and likely correct? |
I believe they are correct. Some values differ by more then a marginal amount, though, such as sin and cos coefficients. But summary values were the same or nearly the same, such as CMB heat flux in dynamic_core |
OK, good to merge once the checks come back green! |
Hmm, are the tests still failing? I must need to do something more |
Did you apply changes-test-results.diff as explained in the pdf manual? |
The diff file has now been applied. Rene helped me apply it and to squash the commits. Hopefully this fixes it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Updated the gravitational constant to match the recommended value from CODATA.
The published value (with standard error in parenthesis) and the reference were added to the comments.
This change aids gravity comparisons of benchmarks with published studies.
Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.
Describe what you did in this PR and why you did it.
Before your first pull request:
For all pull requests: