GMG: fix order of RHS correction [WIP] #4325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure if this makes a difference in test output or if anything else breaks because of it, but this ordering seems correct to me. |
|
@gassmoeller why does "linux / tests" pass? This seems wrong. |
tjhei
changed the title
|
It seems that the prescribed dilation test now fails. I have to think about this some more... |
I think I know what is happening, will investigate and update the workflow (at the moment it only fails if a test creates different output, but not if it crashes). |
|
I have no idea what this patch does, but have you given some more thought to the issue? |
Fix the order of GMG correct_stokes_rhs() and make_pressure_rhs_compatible().
tjhei
force-pushed
the
gmg_correct_rhs_order
branch
from
6815ee3
to
d88e235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the order of GMG correct_stokes_rhs() and make_pressure_rhs_compatible().
this is on top of #4324