Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub linguist language detection overrides #4796

Merged
merged 1 commit into from May 23, 2022

Conversation

sac-bsa
Copy link
Contributor

@sac-bsa sac-bsa commented May 23, 2022

Describe what you did in this PR and why you did it.
I saw that GitHub found ASPECT to be programmed 81% in Gnuplot, and seaarched to see how that could be updated to reflect that this repository is not primarily written in Gnuplot.

  • **/doc/** labels files like benchmark/solcx/doc/solcx.tex and cookbooks/finite_strain/doc/finite_strain.cc as documentation and not code.
  • tests/**/*.gnuplot label the test results as generated while leaving gnuplot figure generating scripts with benchmarks and cookbooks as code.
  • contrib/world_builder/** becomes labeled as vendored as it shouldn't be considered part of the code make up of ASPECT.
    See the guide on other rules that could be added from Linguist's documentation.

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.

This is the new report of ASPECT after this is applied.

percent lines language
91.55% 8987905 C++
3.24% 317704 CMake
1.61% 158267 Jupyter Notebook
1.19% 117076 Shell
0.80% 78828 Python
0.65% 64098 Makefile
0.61% 59807 Gnuplot
0.18% 17633 Sed
0.06% 6264 Dockerfile
0.06% 5541 Perl
0.05% 4703 MATLAB

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! I saw that a while ago, but never took the time to figure out why it was mislabeled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants