Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyre components: move compute engine initialization from _configure() to _init() #219

Closed
baagaard-usgs opened this issue Nov 13, 2020 · 1 comment
Closed

Pyre components: move compute engine initialization from _configure() to _init() #219

baagaard-usgs opened this issue Nov 13, 2020 · 1 comment
Assignees
@baagaard-usgs
Labels
clean up Clean up

Comments

@baagaard-usgs
Copy link
Contributor

Transfer of information from Python to C++ should be in _init() not _configure() in Pyre components.
@baagaard-usgs baagaard-usgs added the deficiency Undesirable behavior or annoying deficiency. label Nov 13, 2020
@baagaard-usgs baagaard-usgs added this to the Release v3.0.0 milestone Nov 13, 2020
@baagaard-usgs baagaard-usgs self-assigned this Nov 13, 2020
@baagaard-usgs baagaard-usgs modified the milestones: Release v3.0.0, Release v3.1 Mar 25, 2021
@baagaard-usgs baagaard-usgs added clean up Clean up and removed deficiency Undesirable behavior or annoying deficiency. labels Apr 22, 2021
@baagaard-usgs
Copy link
Contributor Author

This won't be necessary when we use Pyre 1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baagaard-usgs baagaard-usgs

Labels
clean up Clean up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baagaard-usgs