Implement correct 2d JIT solve! #6
Merged
Merged
Conversation
To correct the 2D JIT solve with correct volume computation, 2 major changes were made: 1. The elements class constructor now takes the total number of elements as an argument along with number of elements in both directions. This is so that `jnp.bincount` can work correctly without having to pass a tracer value to its `length` parameter. 2. Update the `MPMExplicit` flattening/unflattening to include the `velocity_update` parameter to make it work with JIT.
kks32
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have working 2D JIT solvers! Compared results on the
uniaxial_stressTo correct the 2D JIT solve with correct volume computation, 2 major changes were made:
jnp.bincountcan work correctly without having to pass a tracer value to itslengthparameter.MPMExplicitflattening/unflattening to include thevelocity_updateparameter to make it work with JIT.