New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Neptune theme #202

Merged
merged 1 commit into from Nov 4, 2013

Conversation

Projects
None yet
4 participants
@bartvde
Member

bartvde commented Oct 28, 2013

I think a lot of people are tired of seeing the default Ext blue theme, can we switch to the Neptune theme? I'm happy to work on a PR if we have consensus.

http://docs.sencha.com/extjs/4.2.2/extjs-build/examples/build/KitchenSink/ext-theme-neptune/#basic-panels

@juliensam

This comment has been minimized.

Show comment
Hide comment
@juliensam

juliensam Oct 28, 2013

Contributor

I agree that people are tired of the blue theme so I'm +1 for this. We should also point to the ExtJS custom theme documentation. ExtJS4 was easier to theme if I recall correctly: http://docs.sencha.com/extjs/4.2.1/#!/guide/theming

Contributor

juliensam commented Oct 28, 2013

I agree that people are tired of the blue theme so I'm +1 for this. We should also point to the ExtJS custom theme documentation. ExtJS4 was easier to theme if I recall correctly: http://docs.sencha.com/extjs/4.2.1/#!/guide/theming

@marcjansen

This comment has been minimized.

Show comment
Hide comment
@marcjansen

marcjansen Oct 28, 2013

Member

Can we possibly even have a the switcher on the examples? A pull request would be much appreciated.

Member

marcjansen commented Oct 28, 2013

Can we possibly even have a the switcher on the examples? A pull request would be much appreciated.

@marcjansen

This comment has been minimized.

Show comment
Hide comment
@marcjansen

marcjansen Oct 28, 2013

Member

http://docs.sencha.com/extjs/4.2.1/extjs-build/examples/shared/include-ext.js might be nice to control the style depending on the URL parameter or a cookie value.

The method swapStyleSheet will leave you with too much padding between elements when switching from neptune to e.g. classic.

Member

marcjansen commented Oct 28, 2013

http://docs.sencha.com/extjs/4.2.1/extjs-build/examples/shared/include-ext.js might be nice to control the style depending on the URL parameter or a cookie value.

The method swapStyleSheet will leave you with too much padding between elements when switching from neptune to e.g. classic.

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Oct 28, 2013

Member

adding the theme switcher makes sense to me, will work on a PR

Member

bartvde commented Oct 28, 2013

adding the theme switcher makes sense to me, will work on a PR

@chrismayer

This comment has been minimized.

Show comment
Hide comment
@chrismayer

chrismayer Oct 28, 2013

Contributor

I am sure people are fed up with the blue default CSS. But if everyone likes the Neptune one? I am not sure so I would also love to see the switcher within the examples.
@marcjansen is the script you mentioned the one which is used in the official examples offering the combo, like here: http://docs.sencha.com/extjs/4.2.1/extjs-build/examples/feed-viewer/feed-viewer.html

I also agree with @juliensam to point to the possibilty of making your custom theme. Should we offer a tutorial upon the ExtJS theming tutorial? I am not sure cause the Ext one is very detailed.

Contributor

chrismayer commented Oct 28, 2013

I am sure people are fed up with the blue default CSS. But if everyone likes the Neptune one? I am not sure so I would also love to see the switcher within the examples.
@marcjansen is the script you mentioned the one which is used in the official examples offering the combo, like here: http://docs.sencha.com/extjs/4.2.1/extjs-build/examples/feed-viewer/feed-viewer.html

I also agree with @juliensam to point to the possibilty of making your custom theme. Should we offer a tutorial upon the ExtJS theming tutorial? I am not sure cause the Ext one is very detailed.

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Oct 28, 2013

Member

@chrismayer so are you saying you're +1 on including the Ext theme combo box in our examples?

Member

bartvde commented Oct 28, 2013

@chrismayer so are you saying you're +1 on including the Ext theme combo box in our examples?

@chrismayer

This comment has been minimized.

Show comment
Hide comment
@chrismayer

chrismayer Oct 28, 2013

Contributor

Yes, @bartvde

+1 from my side

Contributor

chrismayer commented Oct 28, 2013

Yes, @bartvde

+1 from my side

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Oct 28, 2013

Member

ready for review

Member

bartvde commented Oct 28, 2013

ready for review

@marcjansen

This comment has been minimized.

Show comment
Hide comment
@marcjansen

marcjansen Oct 29, 2013

Member

Nice work, @bartvde. Please merge.

The popup example isn't looking really good in the neptune theme, but I think this is a different story.

Member

marcjansen commented Oct 29, 2013

Nice work, @bartvde. Please merge.

The popup example isn't looking really good in the neptune theme, but I think this is a different story.

bartvde added a commit that referenced this pull request Nov 4, 2013

@bartvde bartvde merged commit f39dbf0 into geoext:master Nov 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment