New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in order for people to extend the GeoExt.data.LayerModel, we need to use... #203

Merged
merged 1 commit into from Oct 28, 2013

Conversation

Projects
None yet
2 participants
@bartvde
Member

bartvde commented Oct 28, 2013

... inheritableStatics for the static function and we need to make sure that inside of the static function createFromLayer we access a static function i.e. getProxy instead of the member proxy

in order for people to extend the GeoExt.data.LayerModel, we need to …
…use inheritableStatics for the static function and we need to make sure that inside of the static function createFromLayer we access a static function i.e. getProxy instead of the member proxy
@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Oct 28, 2013

Member

TIA for any review

Member

bartvde commented Oct 28, 2013

TIA for any review

@juliensam

This comment has been minimized.

Show comment
Hide comment
@juliensam

juliensam Oct 28, 2013

Contributor

I'm +1 for merging this. Documentation for inheritableStatics: http://docs.sencha.com/extjs/4.2.2/#!/api/Ext.Class-cfg-inheritableStatics

Contributor

juliensam commented Oct 28, 2013

I'm +1 for merging this. Documentation for inheritableStatics: http://docs.sencha.com/extjs/4.2.2/#!/api/Ext.Class-cfg-inheritableStatics

bartvde added a commit that referenced this pull request Oct 28, 2013

Merge pull request #203 from bartvde/layermodel
in order for people to extend the GeoExt.data.LayerModel, we need to use... (r=@juliensam)

@bartvde bartvde merged commit 7f17b22 into geoext:master Oct 28, 2013

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Oct 29, 2013

Member

okay there is actually more to this, since GeoExt.data.WmsCapabilitiesLayerModel has a different reader and cannot read from a layer object. I'm now looking into how to properly create a GeoExt.data.WmsCapabilitiesLayerModel from a layer object.

Member

bartvde commented Oct 29, 2013

okay there is actually more to this, since GeoExt.data.WmsCapabilitiesLayerModel has a different reader and cannot read from a layer object. I'm now looking into how to properly create a GeoExt.data.WmsCapabilitiesLayerModel from a layer object.

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Oct 29, 2013

Member

I'm leaning towards making a change in the WmsCapabilitiesReader to call callParent when being passed an array

Member

bartvde commented Oct 29, 2013

I'm leaning towards making a change in the WmsCapabilitiesReader to call callParent when being passed an array

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Oct 29, 2013

Member

see: #206

Member

bartvde commented Oct 29, 2013

see: #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment