New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsuite enhancements from OpenLayers/GeoExt 1 #211

Merged
merged 1 commit into from Nov 12, 2013

Conversation

Projects
None yet
2 participants
@marcjansen
Member

marcjansen commented Nov 11, 2013

@marcjansen

This comment has been minimized.

Show comment
Hide comment
@marcjansen

marcjansen Nov 12, 2013

Member

While you're here, @bartvde, would you mind giving this also a review?

Member

marcjansen commented Nov 12, 2013

While you're here, @bartvde, would you mind giving this also a review?

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Nov 12, 2013

Member

I'm not gonna review this line by line ;-)

But I think it's fine to pull in the latest test suite @marcjansen if you've confirmed it still runs (which it should).

So +1.

Member

bartvde commented Nov 12, 2013

I'm not gonna review this line by line ;-)

But I think it's fine to pull in the latest test suite @marcjansen if you've confirmed it still runs (which it should).

So +1.

@marcjansen

This comment has been minimized.

Show comment
Hide comment
@marcjansen

marcjansen Nov 12, 2013

Member

It runs, thanks for reviewing, Bart.

Member

marcjansen commented Nov 12, 2013

It runs, thanks for reviewing, Bart.

marcjansen added a commit that referenced this pull request Nov 12, 2013

Merge pull request #211 from marcjansen/testsuite-enhancements
Testsuite enhancements from OpenLayers/GeoExt 1

@marcjansen marcjansen merged commit 7a76330 into geoext:master Nov 12, 2013

@marcjansen marcjansen deleted the marcjansen:testsuite-enhancements branch Jun 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment