Add shadowless version of the Fugue icons #5

Merged
merged 2 commits into from Mar 16, 2012

2 participants

@tkrotoff

Hi,

I love the Fugue icons and saw your nice gem.
I've added the shadowless version of the icons (this is the version I use). I've also modified the directory name from icons to fugue-icons. Problem it is that it breaks compatibility with current version.

Rational: people might use multiple icon set and in order to avoid clash names I think the best solution is to prefix the icon set with its name, e.g:

There are other popular icon set like the one from KDE http://www.oxygen-icons.org/?cat=3, Tango http://tango.freedesktop.org/Tango_Icon_Library or from Bootstrap Twitter.

Tell me what you think about it.

Regards,

@geoffgarside
Owner

Thanks for this, I'll look at merging this with the next fugue release to give people a more normal version number to lock to until they can update.

At the same time I'm slightly reluctant to add more icons to the set beyond those being added by the creator as it seems to take about 2 minutes for the icon set to be precompiled by the Rails 3 assets tasks.

@tkrotoff

I've also noticed that precompilation takes a long time (3355 icons x2). Then let's go for 2 separated gems...

@geoffgarside
Owner

That would probably be the best plan. I'll keep the idea of moving the icons directory to fugue-icons and make that change over when the next fugue set comes out. Do you want to take fugue_icons_shadowless_rails then or something like that.

If only we could include precompiled versions in them gem somehow.

@tkrotoff

If you have time for it, do it. Same author, same github, updates at the same time...
I have already famfamfam_flags_rails to play with :) and I guess I will create silk_icons_rails (the existing gem seems to be crappy).

@geoffgarside
Owner

Certainly can, will get it sorted this evening after work.

@tkrotoff

Perfect!

@geoffgarside
Owner

I've pulled your changes into the features/shadowless branch for now and pushed out a fugue_icons_shadowless_rails gem. Once a v3.3.4 is warranted then I'll do the directory rename in fugue_icons_rails as well and merge the features/shadowless into master.

@geoffgarside geoffgarside merged commit 45abada into geoffgarside:master Mar 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment