New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entries marked as paid, but no PayPal funds sent? #608

Closed
printer1975 opened this Issue May 16, 2016 · 11 comments

Comments

Projects
None yet
3 participants
@printer1975

printer1975 commented May 16, 2016

Is there another way that an entrant can get their entries marked as paid without paying through Paypal, or me checking it off in the system? I had two register this weekend, and both are marked as paid.

@geoffhumphrey

This comment has been minimized.

Show comment
Hide comment
@geoffhumphrey

geoffhumphrey May 16, 2016

Owner

No, there isn't a readily apparent way to Joe Schmo user. There is one way buried deep in the code that I know of, but I won't specify it here for obvious reasons.

Owner

geoffhumphrey commented May 16, 2016

No, there isn't a readily apparent way to Joe Schmo user. There is one way buried deep in the code that I know of, but I won't specify it here for obvious reasons.

@printer1975

This comment has been minimized.

Show comment
Hide comment
@printer1975

printer1975 May 16, 2016

Something is going on then. All registered entries received 5/14, 5/15, & 5/16 are showing as paid, but there have been no subsequent payments thru PayPal...

printer1975 commented May 16, 2016

Something is going on then. All registered entries received 5/14, 5/15, & 5/16 are showing as paid, but there have been no subsequent payments thru PayPal...

geoffhumphrey pushed a commit that referenced this issue May 16, 2016

@geoffhumphrey

This comment has been minimized.

Show comment
Hide comment
@geoffhumphrey

geoffhumphrey May 16, 2016

Owner

Have you recently upgraded to 2.1.1? If so, there's a snippet of legacy test code in the brew.sec.php file that will cause this issue, starting at line 240:

<?php 
if ($total_to_pay == 0) $brewPaid = "1";
else $brewPaid = $row_log['brewPaid'];
?>
<input type="hidden" name="brewPaid" value="<?php echo $brewPaid; ?>">

Erasing this snippet should take care of the issue for any entries added subsequently. It has also been removed in the latest commit.

Owner

geoffhumphrey commented May 16, 2016

Have you recently upgraded to 2.1.1? If so, there's a snippet of legacy test code in the brew.sec.php file that will cause this issue, starting at line 240:

<?php 
if ($total_to_pay == 0) $brewPaid = "1";
else $brewPaid = $row_log['brewPaid'];
?>
<input type="hidden" name="brewPaid" value="<?php echo $brewPaid; ?>">

Erasing this snippet should take care of the issue for any entries added subsequently. It has also been removed in the latest commit.

@printer1975

This comment has been minimized.

Show comment
Hide comment
@printer1975

printer1975 May 16, 2016

I didn't touch anything....we had that issue Friday night that you assisted in restoring the DB table that was corrupted. Could it have happened then?

printer1975 commented May 16, 2016

I didn't touch anything....we had that issue Friday night that you assisted in restoring the DB table that was corrupted. Could it have happened then?

@geoffhumphrey

This comment has been minimized.

Show comment
Hide comment
@geoffhumphrey

geoffhumphrey May 16, 2016

Owner

Yes, apologies, I didn't realize you were associated with a hosted account. All hosted accounts were updated. I'll make sure to update with the latest commit today.

Owner

geoffhumphrey commented May 16, 2016

Yes, apologies, I didn't realize you were associated with a hosted account. All hosted accounts were updated. I'll make sure to update with the latest commit today.

@printer1975

This comment has been minimized.

Show comment
Hide comment
@printer1975

printer1975 May 16, 2016

OK, cool, thanks!

printer1975 commented May 16, 2016

OK, cool, thanks!

@ercousin

This comment has been minimized.

Show comment
Hide comment
@ercousin

ercousin May 19, 2016

I see several changes to this file over the last few days.

What is the plan for 2.1.2? I already disabled the php warnings, but I'm a bit confused about what I need to change to avoid this issue...

image

ercousin commented May 19, 2016

I see several changes to this file over the last few days.

What is the plan for 2.1.2? I already disabled the php warnings, but I'm a bit confused about what I need to change to avoid this issue...

image

@ercousin

This comment has been minimized.

Show comment
Hide comment
@ercousin

ercousin May 19, 2016

Also, in my sections/brew.sec.php, that php section shows up at line 481, not 240. Are there different versions of 2.1.1?

image

ercousin commented May 19, 2016

Also, in my sections/brew.sec.php, that php section shows up at line 481, not 240. Are there different versions of 2.1.1?

image

@geoffhumphrey

This comment has been minimized.

Show comment
Hide comment
@geoffhumphrey

geoffhumphrey May 19, 2016

Owner

Erase these lines altogether to avoid the entries being marked as paid erroneously. In the 2.1.1 release file, they are located beginning at 240. Not sure what version of the file you've got, @ercousin - maybe from a commit version?

<?php 
if ($total_to_pay == 0) $brewPaid = "1";
else $brewPaid = $row_log['brewPaid'];
?>
<input type="hidden" name="brewPaid" value="<?php echo $brewPaid; ?>">

In any case, if you download the latest commit and replace those files on your server, things will be good. All hosted accounts have the fix in place.

For 2.1.2, these lines will be stripped out. The original intention was to mark any entries as paid if a user has exceeded the entry fee cap (if enabled); however, the logic wasn't right. Instead, there will be a check AFTER the user submits the entry and is processed by the system.

Owner

geoffhumphrey commented May 19, 2016

Erase these lines altogether to avoid the entries being marked as paid erroneously. In the 2.1.1 release file, they are located beginning at 240. Not sure what version of the file you've got, @ercousin - maybe from a commit version?

<?php 
if ($total_to_pay == 0) $brewPaid = "1";
else $brewPaid = $row_log['brewPaid'];
?>
<input type="hidden" name="brewPaid" value="<?php echo $brewPaid; ?>">

In any case, if you download the latest commit and replace those files on your server, things will be good. All hosted accounts have the fix in place.

For 2.1.2, these lines will be stripped out. The original intention was to mark any entries as paid if a user has exceeded the entry fee cap (if enabled); however, the logic wasn't right. Instead, there will be a check AFTER the user submits the entry and is processed by the system.

@ercousin

This comment has been minimized.

Show comment
Hide comment
@ercousin

ercousin May 19, 2016

I now see it at line 240, must have just been a quirk of notepad++...

Thanks for the follow up. I have 2.1.1 installed with fixes to paths.php (for php notices) and brew.sec.php (for marking paid). Are there any other fixes required for 2.1.1 to get it working?

ercousin commented May 19, 2016

I now see it at line 240, must have just been a quirk of notepad++...

Thanks for the follow up. I have 2.1.1 installed with fixes to paths.php (for php notices) and brew.sec.php (for marking paid). Are there any other fixes required for 2.1.1 to get it working?

@geoffhumphrey

This comment has been minimized.

Show comment
Hide comment
@geoffhumphrey

geoffhumphrey May 19, 2016

Owner

If you've implemented the fixes detailed in issues #607, #609, #610, and #611 as well as this one, you should be good to go (unless other bug reports come in, of course). 2.1.2 is on the way. Target release is May 31.

Owner

geoffhumphrey commented May 19, 2016

If you've implemented the fixes detailed in issues #607, #609, #610, and #611 as well as this one, you should be good to go (unless other bug reports come in, of course). 2.1.2 is on the way. Target release is May 31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment