New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert for open entry registration dependant on registration period not on entry registration period #610

Closed
rmsrosa opened this Issue May 17, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@rmsrosa
Contributor

rmsrosa commented May 17, 2016

Hi,

It seems that the alert for "open entry registration" is showed based on the wrong period. In my case, the entry period had ended but the alert for open entry registration period was still showing because the registration period was still open.

The problem seems to be in line 201 of alerts.sec.php. The condition
<?php if (($registration_open == 1) && ...
should probably be
<?php if (($entry_window_open == 1) && ...

This fix worked for me.

A similar issue happens for the alert for "Entry limit nearly reached", in line 209.

I had this issue in version 2.0.1 but I see that it is still present in 2.1.1. The line numbers above are for version 2.1.1. Those for 2.0.1 are 219 and 227, respectively.

Best,
Ricardo

@geoffhumphrey

This comment has been minimized.

Show comment
Hide comment
@geoffhumphrey

geoffhumphrey May 17, 2016

Owner

@rmsrosa, thank you for reporting the issue and providing a solution. I'll make sure it's updated in the next commit.

Owner

geoffhumphrey commented May 17, 2016

@rmsrosa, thank you for reporting the issue and providing a solution. I'll make sure it's updated in the next commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment