New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry names with an apostrophe don't appear on bottle labels #619

Closed
wvbrewed opened this Issue Jun 4, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@wvbrewed

wvbrewed commented Jun 4, 2016

I recently submitted five entries to a competition page. Only three of the five showed the entry names on the bottle labels; those entries didn't have apostrophes in the name. The other two entries that did have an apostrophe in their name didn't show an entry name on the bottle label.

@geoffhumphrey

This comment has been minimized.

Show comment
Hide comment
@geoffhumphrey

geoffhumphrey Jun 6, 2016

Owner

Hello and thanks for reporting. A couple of questions:

  • Which version of the software were you using at the time?
  • What did the bottle label look like (if possible, print out again from Chrome and use the "save as PDF" function)? Please post it here...
  • Are you a user or an administrator of the installation?

In my initial testing with the latest version, I was not able to replicate the issue.

Owner

geoffhumphrey commented Jun 6, 2016

Hello and thanks for reporting. A couple of questions:

  • Which version of the software were you using at the time?
  • What did the bottle label look like (if possible, print out again from Chrome and use the "save as PDF" function)? Please post it here...
  • Are you a user or an administrator of the installation?

In my initial testing with the latest version, I was not able to replicate the issue.

@wvbrewed

This comment has been minimized.

Show comment
Hide comment
@wvbrewed

wvbrewed Jun 6, 2016

Geoff,

1.) The site is http://kotm.lmhba.org and it appears to use 2.0.0.
2.) The bottle label looked relatively normal but it just didn't have the "Entry Name" field between the "Email" and "Cat/Sub" fields. I have attached an image comparing the two resulting bottle labels. On the left is a screenshot from the label of an entry without an apostrophe in the name that shows the "Entry Name" field; on the right side is a picture I took from a printout of one that did have an apostrophe in the name which resulted in no "Entry Name" field. NOTE: The screenshot and picture taken are of two different submissions. I just wanted to note that since the right one had a "Special/Classic" field and the left one did not but that's only because the submission on the left side didn't require it.
bottle_label

3.) I'm a user of it.

wvbrewed commented Jun 6, 2016

Geoff,

1.) The site is http://kotm.lmhba.org and it appears to use 2.0.0.
2.) The bottle label looked relatively normal but it just didn't have the "Entry Name" field between the "Email" and "Cat/Sub" fields. I have attached an image comparing the two resulting bottle labels. On the left is a screenshot from the label of an entry without an apostrophe in the name that shows the "Entry Name" field; on the right side is a picture I took from a printout of one that did have an apostrophe in the name which resulted in no "Entry Name" field. NOTE: The screenshot and picture taken are of two different submissions. I just wanted to note that since the right one had a "Special/Classic" field and the left one did not but that's only because the submission on the left side didn't require it.
bottle_label

3.) I'm a user of it.

geoffhumphrey pushed a commit that referenced this issue Jun 6, 2016

@geoffhumphrey geoffhumphrey self-assigned this Jun 6, 2016

@geoffhumphrey geoffhumphrey added this to the v2.1.4 Release milestone Jun 6, 2016

@geoffhumphrey geoffhumphrey added the v2.1.4 label Jun 6, 2016

@geoffhumphrey

This comment has been minimized.

Show comment
Hide comment
@geoffhumphrey

geoffhumphrey Jun 6, 2016

Owner

Gotcha. I have confirmed the problem having to do with apostrophes in entry names on the BJCP Official bottle labels (both regular and with barcodes). The latest master commit has code that fixes the issue and it will be incorporated into the next release.

Owner

geoffhumphrey commented Jun 6, 2016

Gotcha. I have confirmed the problem having to do with apostrophes in entry names on the BJCP Official bottle labels (both regular and with barcodes). The latest master commit has code that fixes the issue and it will be incorporated into the next release.

@wvbrewed

This comment has been minimized.

Show comment
Hide comment
@wvbrewed

wvbrewed Jun 6, 2016

Wow. Nice work and turn around time. Keep up the great work on this project. I know those of us that have hands both in the IT field as well as homebrewing greatly appreciate what you're doing with this project.

wvbrewed commented Jun 6, 2016

Wow. Nice work and turn around time. Keep up the great work on this project. I know those of us that have hands both in the IT field as well as homebrewing greatly appreciate what you're doing with this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment