New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Scoresheets By Entry Number (PDF) #731

Closed
jimpdx opened this Issue Feb 3, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@jimpdx
Contributor

jimpdx commented Feb 3, 2017

We do not use Judging numbers in our competitions. Would it be possible to allow site admins to upload by ENTRY or JUDGING number (000023.pdf or similar)? Thank you.

@geoffhumphrey geoffhumphrey self-assigned this Feb 3, 2017

@geoffhumphrey geoffhumphrey added this to the v2.1.10 Release milestone Feb 3, 2017

@geoffhumphrey

This comment has been minimized.

Show comment
Hide comment
@geoffhumphrey

geoffhumphrey Feb 3, 2017

Owner

This would require a bit of a code change, which turns out to be pretty easy to implement. Download the attached zip and upload the files within it to your installation:

  • Upload the brewer_entries.sec.php file to the /sections/ directory
  • Upload the scoresheets.output.php file to the /output/ directory

This will apply to version 2.1.5 and later. Please give it whirl and report back.

This code will be integrated into the next release.

scoresheets_download_update_2017.02.03.zip

Owner

geoffhumphrey commented Feb 3, 2017

This would require a bit of a code change, which turns out to be pretty easy to implement. Download the attached zip and upload the files within it to your installation:

  • Upload the brewer_entries.sec.php file to the /sections/ directory
  • Upload the scoresheets.output.php file to the /output/ directory

This will apply to version 2.1.5 and later. Please give it whirl and report back.

This code will be integrated into the next release.

scoresheets_download_update_2017.02.03.zip

@geoffhumphrey

This comment has been minimized.

Show comment
Hide comment
@geoffhumphrey

geoffhumphrey Feb 3, 2017

Owner

Please note that for the download to function properly, the PDF file name must be 6 digits with leading zeroes (e.g., entry number 0329 would be 000329.pdf).

Owner

geoffhumphrey commented Feb 3, 2017

Please note that for the download to function properly, the PDF file name must be 6 digits with leading zeroes (e.g., entry number 0329 would be 000329.pdf).

@jimpdx

This comment has been minimized.

Show comment
Hide comment
@jimpdx

jimpdx Feb 3, 2017

Contributor

Thanks you @geoffhumphrey! That was quick :) We will make this change on SheBrew and use it later this month. Will let you know if we have any issues.

Contributor

jimpdx commented Feb 3, 2017

Thanks you @geoffhumphrey! That was quick :) We will make this change on SheBrew and use it later this month. Will let you know if we have any issues.

@jimpdx

This comment has been minimized.

Show comment
Hide comment
@jimpdx

jimpdx Feb 3, 2017

Contributor

@geoffhumphrey I applied the change to a 2.1.7 site I had from last Fall. The bulk file upload failed when I added a few scoresheets (possibly permissions) but the single file upload worked. And the scoresheets were visible on "My Entries" so it works great. Might want to modify the Scoresheet upload page as it still says "only judging numbers". Thanks again for the quick update!

Contributor

jimpdx commented Feb 3, 2017

@geoffhumphrey I applied the change to a 2.1.7 site I had from last Fall. The bulk file upload failed when I added a few scoresheets (possibly permissions) but the single file upload worked. And the scoresheets were visible on "My Entries" so it works great. Might want to modify the Scoresheet upload page as it still says "only judging numbers". Thanks again for the quick update!

@geoffhumphrey

This comment has been minimized.

Show comment
Hide comment
@geoffhumphrey

geoffhumphrey Feb 3, 2017

Owner

The bulk upload function worked for me on my test servers. May want to check your permissions.

Will do about modifying the nomenclature on the upload page. I'll be making a commit soon with all of the changes. The updated code will also have enhancements that obfuscate the file names in the URL to prevent users from accessing files on the directory they shouldn't.

Owner

geoffhumphrey commented Feb 3, 2017

The bulk upload function worked for me on my test servers. May want to check your permissions.

Will do about modifying the nomenclature on the upload page. I'll be making a commit soon with all of the changes. The updated code will also have enhancements that obfuscate the file names in the URL to prevent users from accessing files on the directory they shouldn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment