Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/Job/jobs/ in mysql.rs #4

Merged
merged 2 commits into from Sep 13, 2022
Merged

s/Job/jobs/ in mysql.rs #4

merged 2 commits into from Sep 13, 2022

Conversation

autotaker
Copy link
Contributor

@autotaker autotaker commented Sep 13, 2022 •
edited

I found a bug with table name in mysql.rs.

In default configuration (lower_case_table_names=0) of MySQL on linux, table name are case-sensitive.
The table name managing jobs should be jobs, but in some SQL it is referred as Jobs.

As a result, this library does not work with such MySQL servers.

With this PR, I modified every occurrence of Jobs in SQL statements with jobs.

@geofmureithi
Copy link
Owner

Hey, thanks for this. I will do a release ASAP

@geofmureithi geofmureithi changed the base branch from master to develop September 13, 2022 05:24
geofmureithi
geofmureithi approved these changes Sep 13, 2022
View reviewed changes
Copy link
Owner

@geofmureithi geofmureithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@geofmureithi geofmureithi merged commit 80ecb25 into geofmureithi:develop Sep 13, 2022
@geofmureithi geofmureithi mentioned this pull request Sep 19, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geofmureithi geofmureithi geofmureithi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@autotaker @geofmureithi