-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flake8 #30
Merged
Merged
Flake8 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just added a coverage report.
even though the main issue is that you won't know how grammar you're actually covering, that's another story. |
loicgasser
force-pushed
the
flake8
branch
2 times, most recently
from
August 10, 2017 17:32
e31deec
to
7687561
Compare
Many thanks for this. I'll review properly next week when I'm back at work. |
@loicgasser - that's great to have setup. Are you ok with being added to a "Contributers" section in the docs? |
sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #29
I using the default flake8 command to fix the errors.
In the tests I am ignoring line length, as we can have some long mapfile strings.
I fixed most of the errors using autopep8.
A useful command:
autopep8 --in-place --aggressive --aggressive --verbose $(find mappyfile/* -type f -name "*.py" -print)