Skip to content

Principal members of types must not be used in other types. #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 21, 2016

Conversation

sgillies
Copy link
Contributor

@sgillies sgillies commented Feb 8, 2016

@sgillies sgillies added this to the draft-ietf-geojson-01 milestone Feb 8, 2016
@tschaub
Copy link
Member

tschaub commented Feb 9, 2016

Looks good to me.

@mpdaly
Copy link
Contributor

mpdaly commented Feb 10, 2016

👍

@sgillies
Copy link
Contributor Author

@tschaub @mpdaly thanks for the quick feedback! I've got one more question I'm going to ask in the email thread.

GeoJSON objects may be stand-alone or may be in the standard
collection/feature/geometry structure. That's all. Members of
foreign members structured like GeoJSON objects are not
GeoJSON objects.
@sgillies
Copy link
Contributor Author

In 45814c3, I attempt to do what I said I would on the list. @dret @sdrees does it look right to you? I think it needs better wording. I'm open to suggestions.

Allan,

That's not disallowed, but I'm working on text that makes it clear that
since "foo" is a foreign property, GeoJSON semantics do not apply under it.
It's not a Feature object, no matter that it is structured like one.
On Feb 12, 2016 12:43 PM, "Allan Doyle" xxxx@xxxx wrote:

Are we disallowing nesting a GeoJSON object inside another? Here's a
GeoJSON LineString called "foo" embedded in a Feature.

{ "type": "Feature",
"geometry": {
"type": "Polygon",
"coordinates": [
[ [100.0, 0.0], [101.0, 0.0], [101.0, 1.0],
[100.0, 1.0], [100.0, 0.0] ]
]
},
"properties": {
"prop0": "value0",
"prop1": {"this": "that"},
"foo": {
"type": "Feature",
"geometry": {
"type": "LineString",
"coordinates": [
[102.0, 0.0], [103.0, 1.0], [104.0, 0.0], [105.0, 1.0]
]
},
"properties": {
"prop0": "value0",
"prop1": 0.0
}
}
}
}

@sgillies sgillies force-pushed the semantics-exclusive branch from d1588a9 to 6f9de15 Compare February 14, 2016 00:24
@dret
Copy link
Contributor

dret commented Feb 18, 2016

what about changing the heading from "Semantics of GeoJSON members and types are not extensible" to "Semantics of GeoJSON members and types are not changeable"? after all, it is possible to extend semantics with additional members, and that is fine, as long as none of the basic GeoJSON semantics are changed.

@sgillies
Copy link
Contributor Author

With the exception of @dret's suggestion above (which I like), this is good to go. I'll merge later today if there are no objections.

@mpdaly
Copy link
Contributor

mpdaly commented Feb 18, 2016

I'm feeling bad now that we've banned FeatureCollection from having a "properties" member, but not bad enough to stand in the way of progress.

sgillies added a commit that referenced this pull request Feb 21, 2016
Principal members of types must not be used in other types.
@sgillies sgillies merged commit 2035b55 into master Feb 21, 2016
@sgillies sgillies deleted the semantics-exclusive branch February 21, 2016 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants