Permalink
Browse files

Remove elixir 1.3 from travis build; reduce version req to 1.4

  • Loading branch information...
geolessel committed Jan 3, 2019
1 parent 90a293f commit 9c1fbe39f43ad686a6005669b31d8655c40200e1
Showing with 13 additions and 13 deletions.
  1. +0 −1 .travis.yml
  2. +12 −11 README.md
  3. +1 −1 mix.exs
@@ -17,4 +17,3 @@ matrix:
- elixir: 1.6
- elixir: 1.5
- elixir: 1.4
- elixir: 1.3
@@ -10,17 +10,12 @@ components in your Phoenix views is now much easier. Using the Phoenix default
of Webpack, this package can make getting React into your application much
faster than switching over to a different system.

> Note regarding Phoenix version 1.3
> Note regarding Phoenix versions <= 1.3
>
> Phoenix 1.3 and earlier use Brunch by default instead of Webpack for asset compilation.
> Phoenix versions 1.3 and earlier use Brunch by default instead of Webpack for asset compilation.
> The setup for apps using Brunch is different than apps using Webpack. If you'd like to
> read the old guide for 1.3/Brunch, you can read the [Phoenix 1.3 README](README-phoenix-1.3.md).
> Note regarding Phoenix versions < 1.3
>
> This README is written as a guide for Phoenix apps running Phoenix >= 1.3. If you are using a
> version of Phoenix below version 1.3, you can check out the [Phoenix 1.2 README](README-phoenix-1.2.md).

## Installation in 4 (or 5) EASY STEPS!

@@ -74,6 +69,12 @@ Then run (from your `assets` directory)
npm install
```

or

```
yarn
```


### 3. Make sure React and Babel presets are installed

@@ -82,16 +83,16 @@ to make sure we get the packages brunch needs in order to compile our files.

```
# using npm
> npm install react react-dom --save
> npm @babel/preset-env @babel/preset-react --save-dev
npm install react react-dom --save
npm install @babel/preset-env @babel/preset-react --save-dev
```

or

```
# using yarn
> yarn add react react-dom
> yarn add --dev @babel/preset-env @babel/preset-react
yarn add react react-dom
yarn add --dev @babel/preset-env @babel/preset-react
```

We also need to activate those presets from the `assets/.babelrc` file:
@@ -8,7 +8,7 @@ defmodule ReactPhoenix.Mixfile do
[
app: :react_phoenix,
version: @version,
elixir: "~> 1.5",
elixir: "~> 1.4",
build_embedded: Mix.env() == :prod,
start_permanent: Mix.env() == :prod,
package: package(),

0 comments on commit 9c1fbe3

Please sign in to comment.