Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(ServerSide): Remove server side rendering code #24

Merged
merged 8 commits into from Nov 27, 2017

Conversation

Projects
None yet
1 participant
@geolessel
Copy link
Owner

geolessel commented Nov 27, 2017

No description provided.

geolessel added some commits Nov 27, 2017

Remove server-side rendering code for now
It never really worked correctly. In order to get it working
correctly, some fiddliness would have to be done to get react stdio
working correctly. Then, in order for the compiled react components to
be able to be rendered, the compiled render path would have to be
inside node_modules. I don't think that is a great solution, and so to
reduce confusion in the package, let's remove it and make it
experimental instead.

@geolessel geolessel merged commit 05bfd15 into master Nov 27, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.