-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Element] Quadratic Bspline MPM #14
Conversation
…odhinandach/mpm into solver/two-phase-semi-implicit-bspline
…odhinandach/cb-geo-mpm into solver/two-phase-semi-implicit-bspline
…eomechanics/mpm into solver/two-phase-semi-implicit-bspline
…odhinandach/cb-geo-mpm into solver/two-phase-semi-implicit-bspline
…ics/mpm into element/bspline
…ics/mpm into element/bspline
…ics/mpm into element/bspline
…ics/mpm into element/bspline
…om/geomechanics/mpm into element/bspline
@RyotaHashimoto @jgiven100 @yliang-sn This PR is ready to be reviewed. Let me know if there are any suggestions on your end. |
Just want to write some additions to the header explanation. This PR also introduces the following:
Hopefully, these are not too much. Otherwise, I am happy to make separate PRs for each of them. |
@migmolper I think we are ready to shift to LME-MPM. The node neighborhood can now be adjusted via a recursive algorithm. See below: Lines 2217 to 2229 in 9f70987
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bodhinandach Thank you for the implementation. The code seems ok. I added some comments and questions. Please check them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the replies. Let's merge this.
@jgiven100 Any follow-up thoughts? |
No other comments from me. Didn't want to "approve" since a lot of this is out my depth |
Alright, merging in then! |
Describe the PR
This PR adds Quadratic BSpline element implementation for 2D and 3D MPM problems. Some changes are brought to the current code:
.json
file:In the above, node types are defined for each direction following this convention:
I have checked that this works currently for explicit and implicit single-phase and explicit and semi-implicit two-phase codes. In the upcoming days, I will check and implement the following:
Related Issues/PRs
#13
Additional context
Steffen, M., Kirby, R. M., & Berzins, M. (2008). Analysis and reduction of quadrature errors in the material point method (MPM). International journal for numerical methods in engineering, 76(6), 922-948.