Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous Extent - Next Extent - Full Extent highlighted after use #149

Closed
federicogodan opened this issue May 20, 2016 · 7 comments
Closed
Assignees
Milestone

Comments

@federicogodan
Copy link

If next extent (and the other extent options) are pressed one after the other they stay selected in the toolbar until other tool buttom are pressed. I see that prev extent and next extent only work one time after user interaction (cant play pressing prev/next infinite times :-P )

Maybe we can enhance this tools for "remember" more than one step back/next.

@klassenjs
Copy link
Member

I think the intent is to move away from those tools and to using the
browser back and forward buttons to handle application state.
On May 20, 2016 18:49, "federicogodan" notifications@github.com wrote:

If next extent (and the other extent options) are pressed one after the
other they stay selected in the toolbar until other tool buttom are
pressed. I see that prev extent and next extent only work one time after
user interaction (cant play pressing prev/next infinite times :-P )

Maybe we can enhance this tools for "remember" more than one step
back/next.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#149

@federicogodan
Copy link
Author

the buttons tool on app are ok, just need to be enhance. Using browser buttons can confuse some users (in some aplications pressing browser back button take the user out of the aplication) also this restricts the ability to embed the application within a site (using iframes for example)

@tchaddad
Copy link
Contributor

Out of curiosity how many steps would you like to preserve? Myself, I would maybe say 3 at maximum, but I'm not a user of these buttons, so I have no concept of what would be useful.

@federicogodan
Copy link
Author

between 3 and 10 is ok, usually users tend not to go too far back

@theduckylittle theduckylittle self-assigned this Jul 1, 2016
@theduckylittle theduckylittle added this to the 2.9.1 milestone Jul 1, 2016
@theduckylittle
Copy link
Member

This wasn't a problem with the forward/back functionality programmed into GeoMoose but with the way the toolbar buttons were being handled in 2.9. We updated a lot of control interaction and un-selectable tools were apparently missed in that testing.

I think I've fixed the issue but it merits some testing.

@elil
Copy link
Member

elil commented Aug 15, 2016

A quick testing indicates that this works through ten or more zoom extents. Interspersing select, identify, pan, with zoom history clicks appears to not impact extent history. If we keep track of the status of extent history, we could turn these icons on and off at the beginning and end of the history.

@theduckylittle
Copy link
Member

I'm calling it good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants