Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Legend to printable map (PDF output) #99

Closed
tchaddad opened this issue Jul 23, 2015 · 6 comments
Closed

Add Legend to printable map (PDF output) #99

tchaddad opened this issue Jul 23, 2015 · 6 comments

Comments

@tchaddad
Copy link
Contributor

Place a legend showing layers turned on in the PDF output.

As mentioned here: http://lists.osgeo.org/pipermail/geomoose-users/2015-April/005601.html
and here: http://lists.osgeo.org/pipermail/geomoose-users/2015-July/005716.html

More to follow..

@theduckylittle theduckylittle modified the milestones: 2.8.1, 2.9 Dec 21, 2015
theduckylittle pushed a commit to geomoose/geomoose-services that referenced this issue Dec 21, 2015
@theduckylittle theduckylittle self-assigned this Dec 21, 2015
@theduckylittle
Copy link
Member

So, apparently, we did not have legend rendering support. And now we do. Huzzah!

@tchaddad
Copy link
Contributor Author

tchaddad commented Apr 6, 2016

Tested successfully in 97b9ce2 by inserting:<param name="renderLegends">true</param> into the mapbook.xml parameters.

We should consider adding this to the demo mapbook so that users are aware that the option exists.

@elil
Copy link
Member

elil commented Apr 11, 2016

The default mapbook.xml so far has been a balancing act of including the most common elements for example and reference and confusion with unnecessary information. We could also consider the approach of include all options.

I'll add this to the Mapbook Reference Guide. Suggestions on where?

@tchaddad
Copy link
Contributor Author

Understand about the demo. I was thinking that this was a common enough need (it's highly requested) that adding it as <param name="renderLegends">false</param> so that it is turned off by default wouldn't be too intrusive.

As for the reference guide, the logical location is the configuration section at the top (since the guide is laid out like the Mapbook). But since that section mostly consists of copy-paste from the demo...

I assume it will also end up here?: http://docs.geomoose.org/master/docs/configuration.html#configuration

@elil
Copy link
Member

elil commented Apr 11, 2016

Hmm, thinking about it, maybe it is better just in the configuration and not making the reference guide more crowded.

Assuming that our script that makes that page catches it, then yes, every config will be there.

@klassenjs should we update the release process with something about running doc_config_js.py? When does that get run?

theduckylittle pushed a commit to geomoose/geomoose-services that referenced this issue Apr 12, 2016
@theduckylittle
Copy link
Member

I set this as the default and fixed the code in master which had a regression that looked like I was testing some code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants