Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass thru additional parameters for AGS map-source #517

Closed
brentfraser opened this issue Jun 1, 2020 · 8 comments
Closed

pass thru additional parameters for AGS map-source #517

brentfraser opened this issue Jun 1, 2020 · 8 comments

Comments

@brentfraser
Copy link
Contributor

Currently (v3.6.1) only <param name="cross-origin" is passed along from the mapbook.xml to create the AGS layer. It would be nice to pass other AGS-valid parameters, and custom parameters as well. Related to #475

@brentfraser
Copy link
Contributor Author

brentfraser commented Jun 1, 2020

FYI, currently in the demo the request made is

https://services.arcgisonline.com/ArcGIS/rest/services/NatGeo_World_Map/MapServer
/export?
F=image
FORMAT=PNG32
TRANSPARENT=true
SIZE=256,256
BBOX=-10353854.103396835,5545047.7799198255,-10351408.11849171,5547493.764824951
BBOXSR=3857
IMAGESR=3857
DPI=90

The SR definitions of 3857 is curious since the demo is 26915

@brentfraser
Copy link
Contributor Author

brentfraser commented Jun 1, 2020

So I made the following change in ags.js:

    return {
        crossOrigin: cx_origin,
        params: mapSource.params,
        url: mapSource.urls[0]
    }

by adding the params: mapSource.params, and it looks like the mapbook.xml params are being passed along.

@tchaddad
Copy link
Collaborator

tchaddad commented Jun 1, 2020

Thanks Brent - I will give that a try on my end to see if it solves the issue I was dealing with in #475

theduckylittle added a commit to theduckylittle/gm3 that referenced this issue Jun 5, 2020
Small fix to get more to the AGS layers.

refs: geomoose#517
@theduckylittle
Copy link
Member

Added this in PR #534

It may be worthwhile to have a different target AGS server. If folks really want us to test this more deeply. A lot of the AGS functionality came along as "Oh wow! It works!" and could use substantial hardening from folks who work with it on the regular.

@brentfraser
Copy link
Contributor Author

I agree. I find the whole AGS ecosystem confusing, and the GeoMoose nomenclature doesn't help.

  • type="ags" means an ArcGIS Image Server (/MapServer/) accepting image requests
  • type="ags-vector" means an ArcGIS Image Server (/MapServer/) accepting feature query requests, NOT an ArcGIS Feature Server.

I really need to make a table of servers and GM supported requests.

@bfischer-hei
Copy link
Member

bfischer-hei commented Jun 5, 2020 via email

@brentfraser
Copy link
Contributor Author

I think the solution is for us to document what GM supports as of now, add other protocols as needed. And for extra credit, find some public servers and add tests, or at least add a "kitchen-sink" demo to the examples.

@bfischer-hei
Copy link
Member

bfischer-hei commented Jun 5, 2020 via email

theduckylittle added a commit to theduckylittle/gm3 that referenced this issue Jun 21, 2020
Small fix to get more to the AGS layers.

refs: geomoose#517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants