Added configurability to Selection and Results #350
Conversation
* Added the code to allow configuring them from the application constructor. * Moved the style defintions to a defaults module for easier reference, maintenance, and testing down the road. * Added a doc to refer people to.
|
|
||
| ## Change the highlight color | ||
|
|
||
| Pass `resultsStyle.highlight` into the `loadMapbook` options. |
There was a problem hiding this comment.
This doesn't match the example code.
There was a problem hiding this comment.
gm3.Application != loadMapbook
src/gm3/application.js
Outdated
| @@ -248,15 +229,15 @@ class Application { | |||
| url: options.url, | |||
| type: 'xml', | |||
| success: (response) => { | |||
| this.populateMapbook(response); | |||
| this.populateMapbook(response, options); | |||
There was a problem hiding this comment.
populateMapbook only takes one argument
src/gm3/application.js
Outdated
| } | ||
| }); | ||
|
|
||
| } else if(options.content) { | ||
| // this is just straight mapbook xml | ||
| // TODO: Maybe it needs parsed?!? | ||
| const populate_promise = new Promise((resolve, reject) => { | ||
| this.populateMapbook(options.content); | ||
| this.populateMapbook(options.content, options); |
There was a problem hiding this comment.
populateMapbook only takes one argument
| ## GeoMoose vector styles | ||
|
|
||
| All vector styles are styled using the Mapbox GL Styles format. It is Javascript/JSON | ||
| friendly and well documented here. TODO: INSERT LINK. |
There was a problem hiding this comment.
Wow, that's a hard link to find. MapBox GL Styles are well documented, but I gather we must be using some subset of MapBox GL Styles since overall it looks like it more or less is a JSON version of a GeoMoose 2 mapbook.
There was a problem hiding this comment.
https://docs.mapbox.com/mapbox-gl-js/style-spec/#layers
If I had to guess it would be some combination of 'paint' and 'layout' properties (although I don't think we are splitting them out into separate categories).
There was a problem hiding this comment.
There is some current merging of properties -- which is actually why upgrading the ol-mapbox-style library will require more of an upgrade than bumping the version number. The new versions are 'cleaner' about it and we're exercising the library in a way for which the spec was not originally intended.
There was a problem hiding this comment.
Fair enough. The other thing is if updating it breaks the current styles, it would force us into major release which is somewhat undesirable.
|
Did we intend to change the colors in the demo (app.js)? I'd be tempted to leave the lines in app.js but comment them out. Otherwise, it looks ok to me. |
|
Agreed, backed out the changes altogether. |
constructor.
reference, maintenance, and testing down the road.