Skip to content

Graphspace#1244

Merged
ninamiolane merged 13 commits intogeomstats:masterfrom
annacalissano:graphspace
Dec 17, 2021
Merged

Graphspace#1244
ninamiolane merged 13 commits intogeomstats:masterfrom
annacalissano:graphspace

Conversation

@annacalissano
Copy link
Collaborator

metric space for unlabelled graphs

"""
if matcher == "FAQ":
perm = self.faq_matching(base_graph, graph_to_permute)
if matcher == "ID":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: if -> elif


References
----------
..[Calissano2020] Calissano, A., Feragen, A., Vantini, S.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahahah

References
----------
..[Calissano2020] Calissano, A., Feragen, A., Vantini, S.
“Graph Space: Geodesic Principal Components for aPopulation of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: aPopulation -> a Population

Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ma che fantastico!

@ninamiolane ninamiolane merged commit 906180f into geomstats:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants