Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphspace #1244

Merged
merged 13 commits into from
Dec 17, 2021
Merged

Graphspace #1244

merged 13 commits into from
Dec 17, 2021

Conversation

annacalissano
Copy link
Collaborator

metric space for unlabelled graphs

geomstats/geometry/graphspace.py Outdated Show resolved Hide resolved
"""
if matcher == "FAQ":
perm = self.faq_matching(base_graph, graph_to_permute)
if matcher == "ID":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: if -> elif


References
----------
..[Calissano2020] Calissano, A., Feragen, A., Vantini, S.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahahah

References
----------
..[Calissano2020] Calissano, A., Feragen, A., Vantini, S.
“Graph Space: Geodesic Principal Components for aPopulation of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: aPopulation -> a Population

geomstats/geometry/graphspace.py Show resolved Hide resolved
geomstats/geometry/graphspace.py Outdated Show resolved Hide resolved
geomstats/geometry/graphspace.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ma che fantastico!

@ninamiolane ninamiolane merged commit 906180f into geomstats:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants