New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean documentation and TODOs #208

Merged
merged 18 commits into from Dec 31, 2018

Conversation

Projects
None yet
2 participants
@ninamiolane
Copy link
Collaborator

ninamiolane commented Dec 31, 2018

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #208 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files          66       66           
  Lines        8073     8073           
=======================================
  Hits         7576     7576           
  Misses        497      497
Flag Coverage Δ
#numpy 93.5% <100%> (ø) ⬆️
#tensorflow 70.11% <100%> (ø) ⬆️
Impacted Files Coverage Δ
geomstats/matrices_space.py 85.18% <ø> (ø) ⬆️
tests/test_special_euclidean_group.py 99.84% <ø> (ø) ⬆️
geomstats/discretized_curves_space.py 94.26% <ø> (ø) ⬆️
tests/test_euclidean_space.py 99.54% <ø> (ø) ⬆️
geomstats/special_euclidean_group.py 92.14% <ø> (ø) ⬆️
geomstats/stiefel.py 99.4% <ø> (ø) ⬆️
geomstats/visualization.py 89.93% <ø> (ø) ⬆️
geomstats/riemannian_metric.py 94.68% <ø> (ø) ⬆️
geomstats/hypersphere.py 95.8% <ø> (ø) ⬆️
examples/loss_and_gradient_se3.py 92.3% <ø> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e97bcb...a9e8e4d. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #208 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files          66       66           
  Lines        8073     8073           
=======================================
  Hits         7576     7576           
  Misses        497      497
Flag Coverage Δ
#numpy 93.5% <100%> (ø) ⬆️
#tensorflow 70.11% <100%> (ø) ⬆️
Impacted Files Coverage Δ
geomstats/matrices_space.py 85.18% <ø> (ø) ⬆️
tests/test_special_euclidean_group.py 99.84% <ø> (ø) ⬆️
geomstats/discretized_curves_space.py 94.26% <ø> (ø) ⬆️
tests/test_euclidean_space.py 99.54% <ø> (ø) ⬆️
geomstats/special_euclidean_group.py 92.14% <ø> (ø) ⬆️
geomstats/stiefel.py 99.4% <ø> (ø) ⬆️
geomstats/visualization.py 89.93% <ø> (ø) ⬆️
geomstats/riemannian_metric.py 94.68% <ø> (ø) ⬆️
geomstats/hypersphere.py 95.8% <ø> (ø) ⬆️
examples/loss_and_gradient_se3.py 92.3% <ø> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e97bcb...a9e8e4d. Read the comment docs.

@ninamiolane ninamiolane requested a review from johmathe Dec 31, 2018

@johmathe johmathe merged commit ce31656 into master Dec 31, 2018

4 checks passed

codecov/patch 100% of diff hit (target 93.84%)
Details
codecov/project 93.84% (+0%) compared to 6e97bcb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment