Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prelimenary fixes #267

Merged
merged 9 commits into from Jan 14, 2020
Merged

prelimenary fixes #267

merged 9 commits into from Jan 14, 2020

Conversation

@nguigs
Copy link
Collaborator

nguigs commented Jan 14, 2020

-Condition for while loop in mean alg
-So3: -fix random uniform when point_type=matrix
-different belong when point_type=matrix to avoid inverting: will crash if a singular matrix is passed

nguigs added 9 commits Jan 13, 2020
rebase
sync
sync
sync
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 14, 2020

Codecov Report

❗️ No coverage uploaded for pull request base (master@3e1280a). Click here to learn what that means.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #267   +/-   ##
=========================================
  Coverage          ?   91.44%           
=========================================
  Files             ?       82           
  Lines             ?     9001           
  Branches          ?        0           
=========================================
  Hits              ?     8231           
  Misses            ?      770           
  Partials          ?        0
Flag Coverage Δ
#numpy 88.79% <83.33%> (?)
#pytorch 42.39% <44.44%> (?)
Impacted Files Coverage Δ
tests/test_special_orthogonal_group.py 99.75% <100%> (ø)
geomstats/geometry/special_orthogonal_group.py 93.42% <100%> (ø)
geomstats/backend/pytorch.py 80.55% <100%> (ø)
geomstats/geometry/riemannian_metric.py 89.49% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e1280a...fa936d0. Read the comment docs.

@ninamiolane ninamiolane merged commit 386be6d into geomstats:master Jan 14, 2020
3 checks passed
3 checks passed
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nguigs nguigs deleted the nguigs:nguigs-mean branch Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.