Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #9 resource auth #259

Merged
merged 6 commits into from Jul 3, 2019

Conversation

@justb4
Copy link
Member

commented Jul 2, 2019

Implements a generic Resource Authentication framework:

  • using GHC Plugins (for UI forms, metadata and encoding)
  • uses Authorization HTTP header
  • two methods (Plugin Classes) implemented: Basic Auth (username+password) and Bearer Token (token string)
  • secured/encrypted creds storage
  • tested with several secured OWS endpoint

@justb4 justb4 added the enhancement label Jul 2, 2019

@justb4 justb4 added this to the Version 0.7.0 milestone Jul 2, 2019

@justb4 justb4 requested a review from tomkralidis Jul 2, 2019

@justb4 justb4 self-assigned this Jul 2, 2019

@tomkralidis

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Thanks @justb4. Overall no objections. Is the functionality for resource based auth, locking down an entire GHC instance, or both?

@justb4

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

Thanks @justb4. Overall no objections. Is the functionality for resource based auth, locking down an entire GHC instance, or both?

Don't know if I understand the question. This PR is only for optional per-Resource auth, completely independent from general GHC auth. To secure an entire GHC instance (making it only accessible via user-login, usually admin) issue #254 has been implemented.

btw the reason Travis fails is that the default config in unit tests misses the s-key. Fix upcoming.

@tomkralidis

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

@justb4 ah, ok. +1.

@justb4 justb4 added this to In progress in Stantec NL sponsored development Jul 3, 2019

@justb4 justb4 merged commit 3abff6a into geopython:master Jul 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@justb4 justb4 moved this from In progress to Done in Stantec NL sponsored development Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.