Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#305 replace func_name and type.StringTypes to Py3 valid equivalents … #306

Merged
merged 1 commit into from Nov 28, 2019

Conversation

@justb4
Copy link
Member

justb4 commented Nov 28, 2019

Two small changes to fix issue:

  • use __name__ i.s.o. func_name function attr
  • use isinstance(expr, str) i.s.o. isinstance(expr, types.StringTypes)

Tested: notifications email now works again.

…- should fix issue
@justb4 justb4 self-assigned this Nov 28, 2019
@justb4 justb4 added the bug label Nov 28, 2019
@justb4 justb4 added this to the Version 0.8.0 milestone Nov 28, 2019
@justb4 justb4 merged commit c87fb16 into master Nov 28, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.