You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi propably there is a little bug at this line https://github.com/geopython/OWSLib/blob/master/owslib/map/wms130.py#L507
The way how the scale is currently read, is based on the WMS 1.1.1 specification. According to the official OGC WMS 1.3.0 specification http://portal.opengeospatial.org/files/?artifact_id=14416 on page 27 the scale is now represented by two XML-Tags <MinScaleDenominator> and <MaxScaleDenominator>.
Someone already added a testcase where the MaxScaleDenominator exists https://github.com/geopython/OWSLib/blob/master/tests/resources/wms_dov_getcapabilities_130.xml.
So this
sh = elem.find(nspath('ScaleHint', WMS_NAMESPACE))
self.scaleHint = None
if sh is not None:
if 'min' in sh.attrib and 'max' in sh.attrib:
self.scaleHint = {'min': sh.attrib['min'], 'max': sh.attrib['max']}
might be changed to
minScale = elem.find(nspath('MinScaleDenominator', WMS_NAMESPACE))
maxScale = elem.find(nspath('MaxScaleDenominator', WMS_NAMESPACE))
self.scaleHint = None
min = minScale if minScale is not None else 1
max = maxScale if maxScale is not None else None
if max is not None:
self.scaleHint = {'min': min, 'max': max}
The text was updated successfully, but these errors were encountered:
Hi propably there is a little bug at this line
https://github.com/geopython/OWSLib/blob/master/owslib/map/wms130.py#L507
The way how the scale is currently read, is based on the WMS 1.1.1 specification. According to the official OGC WMS 1.3.0 specification
http://portal.opengeospatial.org/files/?artifact_id=14416
on page 27 the scale is now represented by two XML-Tags<MinScaleDenominator>
and<MaxScaleDenominator>
.Someone already added a testcase where the MaxScaleDenominator exists
https://github.com/geopython/OWSLib/blob/master/tests/resources/wms_dov_getcapabilities_130.xml
.So this
might be changed to
The text was updated successfully, but these errors were encountered: