Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOS2.0 and WaterML2.0 #241

Merged
merged 12 commits into from Jun 20, 2016
Merged

SOS2.0 and WaterML2.0 #241

merged 12 commits into from Jun 20, 2016

Conversation

kwilcox
Copy link
Member

@kwilcox kwilcox commented May 22, 2015

This is a manual rebase of #171 onto master along with a few small fixes in the PR.

@kwilcox kwilcox changed the title Peter SOS2.0 May 22, 2015
@kwilcox kwilcox changed the title SOS2.0 SOS2.0 and WaterML2.0 May 22, 2015
@tomkralidis
Copy link
Member

@kwilcox thanks for this. Looks like some associated test failures?

@kwilcox
Copy link
Member Author

kwilcox commented Jul 2, 2015

@tomkralidis all service endpoint test failures now

@jachym jachym force-pushed the master branch 5 times, most recently from 640ed63 to d5d062b Compare July 4, 2015 13:43
@peterataylor
Copy link

Hi guys,

Any updates on this? The build failures were due to non responsive services called from the doc tests. Do you want to try and capture potential fails or change the service endpoint in the doctest? The general issue is service stability + longevity - can't really be sure all test services will be up.

@kwilcox
Copy link
Member Author

kwilcox commented Mar 3, 2016

Slipped off my radar. I can rebase onto master so it can be merged. The test services going down is a long standing issue... I just opened an issue for it: #312

@peterataylor
Copy link

Thanks Kyle. That would be great if you could rebase; let me know if I can help.

@kwilcox
Copy link
Member Author

kwilcox commented Apr 12, 2016

@peterataylor Do you know of any SOS2.0 servers I can rewrite the tests against? It took me so long... they have all gone away.

@tomkralidis
Copy link
Member

@peterataylor
Copy link

Thanks @kwilcox . Actually I've recently been testing a new SOS2.0 service at the Bureau of Met here: http://www.bom.gov.au/waterdata/service. I have a py notebook using it here: http://nbviewer.jupyter.org/github/peterataylor/bom-water-data-service-example/blob/master/bom-water-sos-example.ipynb.

This is likely to be quite a stable service - so a good candidate for the test suite. I can help to integrate it if need be.

@domlowe
Copy link
Member

domlowe commented Apr 13, 2016

Good idea Pete. Typo in the URL - should be:
http://www.bom.gov.au/waterdata/services

@kwilcox
Copy link
Member Author

kwilcox commented Apr 25, 2016

@peterataylor I'm not having much luck with that service... does your notebook work? Do you have more commits to add?

@peterataylor
Copy link

Hi @kwilcox - yes sorry there were two additional changes I had to make to get it fully working: peterataylor@9274f8e. One is the way the Bureau service describes its endpoints in the caps document - the base URL is incorrect. I had to put in a temporary hack in to get it to work. I've reported the issue. We obviously don't want this fix in the library, so may be a blocker until we can get the service fixed..?

The second was adding observed_properties to the service metadata where the observed properties are not contained within an offering (they are inherited across all offerings).

@kwilcox
Copy link
Member Author

kwilcox commented Apr 28, 2016

Please don't merge, waiting for other PRs to be merged first and ill rebase

@kwilcox
Copy link
Member Author

kwilcox commented May 24, 2016

This is ready to merge. The test failures are all broken or changing external services (which we really need to fix).

@@ -654,6 +654,9 @@ def __init__(self, md=None):
val = md.find(util.nspath_eval('srv:accessProperties/gmd:MD_StandardOrderProcess/gmd:fees/gco:CharacterString', namespaces))
self.fees = util.testXMLValue(val)

val = md.find(util.nspath_eval('srv:accessProperties/gmd:MD_StandardOrderProcess/gmd:fees/gco:CharacterString', namespaces))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a duplicated by accident?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup bad merge, will remove

@peterataylor
Copy link

Hi Tom - anything blocking this one now? Just want to avoid Kyle's updated PR diverging again..

@tomkralidis tomkralidis merged commit c73c06e into geopython:master Jun 20, 2016
@tomkralidis
Copy link
Member

Squashed and merged -- thanks @peterataylor / @kwilcox !

@cehbrecht cehbrecht mentioned this pull request Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants