New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOS2.0 and WaterML2.0 #241
Conversation
@kwilcox thanks for this. Looks like some associated test failures? |
@tomkralidis all service endpoint test failures now |
640ed63
to
d5d062b
Compare
Hi guys, Any updates on this? The build failures were due to non responsive services called from the doc tests. Do you want to try and capture potential fails or change the service endpoint in the doctest? The general issue is service stability + longevity - can't really be sure all test services will be up. |
Slipped off my radar. I can rebase onto |
Thanks Kyle. That would be great if you could rebase; let me know if I can help. |
@peterataylor Do you know of any SOS2.0 servers I can rewrite the tests against? It took me so long... they have all gone away. |
Thanks @kwilcox . Actually I've recently been testing a new SOS2.0 service at the Bureau of Met here: http://www.bom.gov.au/waterdata/service. I have a py notebook using it here: http://nbviewer.jupyter.org/github/peterataylor/bom-water-data-service-example/blob/master/bom-water-sos-example.ipynb. This is likely to be quite a stable service - so a good candidate for the test suite. I can help to integrate it if need be. |
Good idea Pete. Typo in the URL - should be: |
@peterataylor I'm not having much luck with that service... does your notebook work? Do you have more commits to add? |
Hi @kwilcox - yes sorry there were two additional changes I had to make to get it fully working: peterataylor@9274f8e. One is the way the Bureau service describes its endpoints in the caps document - the base URL is incorrect. I had to put in a temporary hack in to get it to work. I've reported the issue. We obviously don't want this fix in the library, so may be a blocker until we can get the service fixed..? The second was adding observed_properties to the service metadata where the observed properties are not contained within an offering (they are inherited across all offerings). |
Please don't merge, waiting for other PRs to be merged first and ill rebase |
support for decoding WaterML2.0 and general Observations & Measurement types.
This is ready to merge. The test failures are all broken or changing external services (which we really need to fix). |
@@ -654,6 +654,9 @@ def __init__(self, md=None): | |||
val = md.find(util.nspath_eval('srv:accessProperties/gmd:MD_StandardOrderProcess/gmd:fees/gco:CharacterString', namespaces)) | |||
self.fees = util.testXMLValue(val) | |||
|
|||
val = md.find(util.nspath_eval('srv:accessProperties/gmd:MD_StandardOrderProcess/gmd:fees/gco:CharacterString', namespaces)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a duplicated by accident?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup bad merge, will remove
Hi Tom - anything blocking this one now? Just want to avoid Kyle's updated PR diverging again.. |
Squashed and merged -- thanks @peterataylor / @kwilcox ! |
This is a manual rebase of #171 onto master along with a few small fixes in the PR.