Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py38 #635

Merged
merged 3 commits into from Dec 30, 2019
Merged

Py38 #635

merged 3 commits into from Dec 30, 2019

Conversation

ocefpaf
Copy link
Contributor

@ocefpaf ocefpaf commented Dec 25, 2019

Added py38 to the test matrix and fixed cgi.parse_qsl deprecation.

Note that the current code is broken on Python 3.8 without these changes.

@fmigneault
Copy link
Contributor

@ocefpaf
Would it be possible to have this tagged as 0.19.1 or similar to bump the version in pypi?
At the moment, anyone using Python 3.8 will automatically receive an error due to cgi deprecation when installing latest owslib.

@cehbrecht
Copy link
Contributor

@tomkralidis How about a 0.19.1 release? I can update the changes:
https://github.com/geopython/OWSLib/issues?q=is%3Aclosed+milestone%3A0.20.0

@ocefpaf
Copy link
Contributor Author

ocefpaf commented Jan 28, 2020

@ocefpaf
Would it be possible to have this tagged as 0.19.1 or similar to bump the version in pypi?

I don't have the proper rights here to do so but @cehbrecht is already on it.

At the moment, anyone using Python 3.8 will automatically receive an error due to cgi deprecation when installing latest owslib.

If you are using the conda-forge version of the package we backported this change and you should be good to go.

@fmigneault
Copy link
Contributor

@cehbrecht Thanks for looking into this.
@ocefpaf I'm not using the conda package, using directly the pip requirements.
I'll wait for the version whenever it is available.

@tomkralidis
Copy link
Member

@cehbrecht sure, ping me once changes are updated and I will cut 0.19.1

@cehbrecht
Copy link
Contributor

@tomkralidis changes done ... just wait for PR #628.

@cehbrecht
Copy link
Contributor

@tomkralidis I think we are good to go for 0.19.1.

@tomkralidis
Copy link
Member

thanks @cehbrecht . 0.19.1 released.

@fmigneault
Copy link
Contributor

Thanks to all of you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants