review of the setup document & fix typos in ld article #53
Conversation
| Here we override the default configuration which resides at `/pygeoapi/local.config.yml` within the Container | ||
| with our local file [default.config.yml](https://github.com/geopython/pygeoapi/blob/master/docker/default.config.yml) | ||
| by using Docker Volume Mount (`-v` option). A Docker Volume mount attaches, 'mounts', a | ||
| In the upcoming exercises we are going to update the configuration file multiple times. |
There was a problem hiding this comment.
Hmm, in reality there is already a pygeoapi config in the workshop materials (now under docker/pygeoapi/docker.config.yml) which is mounted via docker-compose and modified in the exercises.
Suggestion is to mount that file in this exercise here.
Also think we should have a Docker Compose with that file mounted in this section as to prepare for "first.md"
There was a problem hiding this comment.
it could also make sense to first run directly on a container, before going into the compose use case
fix typos in ld article
pvgenuchten
force-pushed
the
local_links
branch
5 times, most recently
from
c4d5a33
to
4b78e61
Compare
| !!! question "Docker in the background" | ||
|
|
||
| 1. Type `docker-compose up -d` | ||
| 1. Type `docker ls`; verify that the pygeoapi container is running |
workshop/content/docs/setup/index.md
Outdated
| [Docker Compose](https://docs.docker.com/compose/) is an addition to Docker to facilitate | ||
| the orchestration of one or more Docker 'Containers' (a Container is a running instance of a Docker Image) | ||
| [Docker Compose](https://docs.docker.com/compose/) is an addition to docker to facilitate | ||
| the orchestration (configuration) of one or more Docker 'Containers' (a Container is a running instance of a docker image) |
There was a problem hiding this comment.
same here 'Docker Image` (and Container) all capitalized.
There was a problem hiding this comment.
Image and Container not sure, they are not names; check at https://en.wikipedia.org/wiki/Docker_(software), they use image and container
pvgenuchten
force-pushed
the
local_links
branch
from
4b78e61
to
23e1714
Compare
|
updated to use |
|
Indeed product names like Docker Compose capitalised, but artefacts like 'image' and 'container' lowercase. |
|
we may have to fix Compose then (other pr) |
i aligned the layout with other pages and updated some of the text/snippets
@justb4, what do you think