ldapadmin - administrators can modify users' uid #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evolution funded by CIGALsace (https://github.com/camptocamp/georchestra-cigalsace-configuration/issues/531) Enables the ability for LDAP administrators (members of MOD_LDAPADMIN) to modify the user id (uid) of the users LDAP entries. The uid field is not like the others attributes and need extra work to implement the ability to modify it, since it is part of the DN qualification ; it requires to "move" the LDAP entry, which is not the same as updating a regular attribute. It also requires to get the users groups and update the member entry. Tests: Utests + tests against a real ldap adapted / OK Runtime tests OK
|
Please do not merge yet |
- Adding synchronized on CRUD operations from AccountDaoImpl to avoid race conditions (Note: might not the best way to do, but this is what was already done onto GroupDao). - Adding a test to cover modifyUser(Account, Account), tested against a real ldap.
|
Should be good to go now. |
| @@ -75,5 +84,36 @@ public void testBlankFields_issues_1086_1096() throws Exception { | |||
| assertTrue("Found a 'o' attribute, expeceted none", noOrgAnymore); | |||
|
|
|||
| } | |||
|
|
|||
| @Test | |||
| public void testUpdateAcountAccount() throws Exception { | |||
There was a problem hiding this comment.
because the method signature is update(Account old, Account new), and I did not have any imagination for a test name :)
|
OK, LGTM, thanks Pierre, please merge. |
|
Missing the "send a mail feature", I will work on it before merging. |
pmauduit
added a commit
to georchestra/template
that referenced
this pull request
Nov 3, 2015
Tests: - Mainly tested at runtime, expected mail provided to the mailserver - Testsuite OK
|
good to go. |
|
LGTM, please merge ! |
pmauduit
added a commit
that referenced
this pull request
Nov 3, 2015
ldapadmin - administrators can modify users' uid
|
Looks like there's a small side-effect ... |
| @@ -61,6 +61,7 @@ shared.download_form.pdfurl= | |||
| shared.ldapadmin.contextpath=/ldapadmin | |||
| shared.ldapadmin.db=georchestra | |||
| shared.ldapadmin.jdbcurl=jdbc:postgresql://@shared.psql.host@:@shared.psql.port@/@shared.ldapadmin.db@ | |||
| shared.ldapadmin.warnifuidmodified=true | |||
There was a problem hiding this comment.
My mistake, this is not a real shared maven filter. It only belongs to ldapadmin.
=> should not be set in config/shared.maven.filters but in build_support/GenerateConfig.groovy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evolution funded by CIGALsace (https://github.com/camptocamp/georchestra-cigalsace-configuration/issues/531).
Enables the ability for LDAP administrators (members of MOD_LDAPADMIN) to modify the user id (uid) of the users LDAP entries.
The uid field is not like the others attributes and need extra work to implement the ability to modify it, since it is part of the DN qualification ; it requires to "move" the LDAP entry, which is not the same as updating a regular attribute.
It also requires to get the users groups and update the member entry (server-side but also client-side in the js objects).
Tests: