Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console - organisation name containing non ascii char breaks SP #3049

Open
fvanderbiest opened this issue Apr 27, 2020 · 3 comments
Open

console - organisation name containing non ascii char breaks SP #3049

fvanderbiest opened this issue Apr 27, 2020 · 3 comments
Labels

Comments

@fvanderbiest
Copy link
Member

We recently had this issue where an org name contained a French quote (like Communauté de Communes de la Région dʼA) and this broke user access to the platform, since the SP was not able to cope with it.

@pmauduit
Copy link
Member

That is not exactly the SP which cannot cope with it: it only takes the values from the OpenLDAP (where the strings can be stored in whatever charset) and put them in the HTTP headers.

This post on stackoverflow is quite interesting and well sourced on the topic: https://stackoverflow.com/questions/4400678/what-character-encoding-should-i-use-for-a-http-header
but they advise to use plain ASCII chars in the http headers (even if the specs specifies that ISO-8859 chars are ok, which might explain that the "é" accented chars are ok, but clearly the "apostrophe française" was too much to pass through and reach some touchy proxyfied servers).

In our case, the georchestra webapps (jetty) were OK with the seg-orgname headers, but the Apache HTTP2 which hosts a drupal CMS was not.

@pmauduit
Copy link
Member

Back to the issue, I see two things:

  • either normalize the string before adding the headers
  • either avoid (in the console UI ? server-side in the console code ?) having unicorns emojis in the organization names ;-)

@fvanderbiest
Copy link
Member Author

I think we should avoid having these in the LDAP, which means having a string validator in the console UI and backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants