Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mapfishapp: fullscreen addon #981

Closed
fvanderbiest opened this issue May 20, 2015 · 6 comments
Closed

mapfishapp: fullscreen addon #981

fvanderbiest opened this issue May 20, 2015 · 6 comments
Assignees
@fvanderbiest
Labels
3 - Done enhancement
Milestone
15.12

Comments

@fvanderbiest
Copy link
Member

See http://geofao.org.bo/mapfishapp/app/addons/fullscreen/manifest.json or (mirror) https://gist.github.com/fvanderbiest/b004818d8bd3f77cce02

Would be good to see it more widely deployed => review + integration in geOrchestra sources
@fvanderbiest fvanderbiest self-assigned this May 20, 2015
@MaelREBOUX
Copy link
Member

Would be great to add it to the 15.12 milestone.

@fvanderbiest
Copy link
Member Author

IIRC CIGALsace is very interested by this one too for 15.12

pmauduit added a commit to pmauduit/georchestra that referenced this issue Aug 18, 2015
@pmauduit
mapfishapp - adding the fullscreen addon
4782e5e 
contributed by geobolivia - see issue georchestra#981
pmauduit added a commit to pmauduit/georchestra that referenced this issue Aug 18, 2015
@pmauduit
mapfishapp - adding the fullscreen addon
4041a20 
contributed by geobolivia - see issue georchestra#981
pmauduit added a commit to pmauduit/georchestra that referenced this issue Aug 18, 2015
@pmauduit
mapfishapp - adding the fullscreen addon
f49fe25 
contributed by geobolivia - see issue georchestra#981
pmauduit added a commit to pmauduit/georchestra that referenced this issue Aug 31, 2015
@pmauduit
mapfishapp - adding the fullscreen addon
138b8dc 
contributed by geobolivia - see issue georchestra#981
@fvanderbiest fvanderbiest added this to the 15.12 milestone Oct 13, 2015
@fvanderbiest
Copy link
Member Author

Expected compatibility with IE >= 10

@fvanderbiest
Copy link
Member Author

http://caniuse.com/#feat=fullscreen says the API is supported by IE >= 11
As a result, the addon will work in a degraded fashion when the API is not supported: sidebars will be collapsed.

fvanderbiest added a commit that referenced this issue Oct 13, 2015
@fvanderbiest
fullscreen addon - see #981
2ed1ae5
fvanderbiest added a commit that referenced this issue Oct 13, 2015
@fvanderbiest
fullscreen addon - see #981
076d3f3
@fvanderbiest fvanderbiest mentioned this issue Oct 13, 2015
Merged
@fvanderbiest
Copy link
Member Author

http://sdi.georchestra.org/mapfishapp/

Tiles are not always loading at the edges, when fullscreened ... I'm wondering if the map div has the correct size...

Please report other potential issues.

@fvanderbiest
Copy link
Member Author

All done, with documentation: https://github.com/georchestra/georchestra/blob/15.06/mapfishapp/src/main/webapp/app/addons/fullscreen/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fvanderbiest fvanderbiest

Labels
3 - Done enhancement
Projects
None yet
Milestone
15.12
Development

No branches or pull requests
2 participants
@fvanderbiest @MaelREBOUX