Osm2geor #1031

Merged
merged 19 commits into from Sep 27, 2015

Projects

None yet

7 participants

@fvanderbiest
Member

Porting @pmauduit 's addon to geOrchestra 14.12 and later (using OpenLayers' built in OSM format rather than a server side component).

It should work right now, but some more work is needed (translations, factorization ...)

The drawback of using client-side parsing of OSM data is that we miss the nice features that pmauduit had crafted on the server side (polygon detection and so on).

The good part is that it is already available for everyone.

@fvanderbiest fvanderbiest self-assigned this Aug 21, 2015
@fvanderbiest fvanderbiest added this to the 15.12 milestone Aug 21, 2015
@pmauduit
Member

Thanks for the initiative ;-)

Since you are doing everything from my code or porting some other parts client-side, I call myself out of the review (LGTM anyway :P)

@fvanderbiest
Member

Looks better now.
Missing spanish and german translations in manifest.json

@fvanderbiest
Member

Maybe we should investigate a bit more the OSM format options (eg: areaTags).

@fvanderbiest
Member
  • missing loading indicator
@fvanderbiest
Member
<fphg> petite idée d'amélioration : ajouter une liste de requêtes preset
<fphg> ... à prendre dans GEOR_config.js avec titre, request, style
@fvanderbiest
Member

Merci @Louca2014 pour

"es": {
            "OSM data": "Datos OSM",
            "This addon allows you to display OSM data in your map": "Esta herramienta le permite mostrar datos OSM en su mapa",
            "OSM to geOrchestra": "OSM a geOrchestra",
            "Query": "Consulta",
            "Style": "Estilo",
            "Keep previously loaded features": "Conservar los objetos existentes",
            "Execute": "Ejecutar",
            "Osm2Geor_HELP_URL": "http://wiki.openstreetmap.org/wiki/Overpass_API/Language_Guide"
@fvanderbiest
Member

@jpklipfel : est-ce que CIGAL pourrait m'aider à traduire ceci en allemand ?

        "de": {
            "OSM data": "Données OSM",
            "This addon allows you to display OSM data in your map": "Cet addon vous permet d'afficher des données OSM dans votre carte",
            "OSM to geOrchestra": "OSM vers geOrchestra",
            "Query": "Requête",
            "Style": "Style",
            "Keep previously loaded features": "Conserver les objets existants",
            "Execute": "Exécuter"
        }

Merci !

@jpklipfel
Contributor

Hello,

    "de": {
        "OSM data": "OSM-Daten",
        "This addon allows you to display OSM data in your map": "Dieses Add-on ermöglicht es die OSM-Daten in Ihrer Karte anzuzeigen",
        "OSM to geOrchestra": "OSM zu geOrchestra",
        "Query": "Abfrage",
        "Style": "Style",
        "Keep previously loaded features": "Zuvor hinzugeladene Objekte beibehalten",
        "Execute": "Ausführen"
    }

Merci au SIGRS/GISOR !

@fvanderbiest
Member

Looks better and better :-)
Thanks everyone. Releasing soon...

@fvanderbiest
Member

Current status...
capture du 2015-09-25 22 09 20

@fphg
Member
fphg commented Sep 25, 2015

sweet :)

@fvanderbiest
Member

Please help me provide default requests and / or styles, thanks :-)

@fvanderbiest
Member

I think it's good to go, now.
Please test and report issues before I merge into 14.12. Thanks.

@fphg
Member
fphg commented Sep 26, 2015

Running on 15.06 dev.geobretagne.fr

the request list is nice and shows potential.
"label": "${_name}" is always returning "undefined". 'Undefined' should'nt be labelled.
changing to "label": "${_name}" shows some non-null labels.
"Openlayers" stylename is cryptic (orange ?)

Anyway, the default conf is just a sample, now it's up to each SDI.
Great work !

@fvanderbiest
Member

"label": "${_name}" is always returning "undefined". 'Undefined' should'nt be labelled.
changing to "label": "${_name}" shows some non-null labels.

Strange, because c8c1958 should prevent this when using "${_name}" as label.
"${name}" is the raw name, and it can be undefined, true

@fvanderbiest
Member

Strange

OK, I get it.
You probably did not update GEOR_util.js, which is required to get correct labels.

@fvanderbiest fvanderbiest merged commit faebf4f into 14.12 Sep 27, 2015
@fvanderbiest fvanderbiest deleted the osm2geor branch Sep 27, 2015
@fvanderbiest
Member

Cascade merge done => now available for everyone on 14.12, 15.06 and master.

@fvanderbiest fvanderbiest added the 14.12 label Sep 27, 2015
@landryb
Member
landryb commented Sep 28, 2015

area["boundary"="administrative"]["admin_level"=8]{{BBOX}}; queries administrative boundaries of level 8, but here JS blows my web browser even on a small bbox.

@fvanderbiest
Member

but here JS blows my web browser even on a small bbox.

Not surprising ... ;-)
capture du 2015-09-28 10 45 57

@fvanderbiest
Member

Those who'd like to install this addon in their 14.12 or 15.06 instances should :

  • add the addon config in their mapfishapp's GEOR_custom.js file, see the related documentation
  • redeploy their security-proxy and mapfishapp from updated sources
@rafemoro

Congratulations, I am now testeando, hopefully soon include GeoBolivia
captura de pantalla de 2015-09-29 12 09 24

@fvanderbiest
Member

Congratulations, I am now testeando, hopefully soon include GeoBolivia

Happy to hear that it will be useful to people around the globe ;-)

@fvanderbiest
Member

Those who plan to use this addon to improve their own databases must not forget that the OSM license is viral, which means that copying a single feature from the OSM database will require their own database to be redistributed under the terms of the ODBL as well.

@fvanderbiest
Member

... which does not mean that it cannot be used as a hint for missing features ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment