New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osm2geor #1031

Merged
merged 19 commits into from Sep 27, 2015

Conversation

Projects
None yet
7 participants
@fvanderbiest
Member

fvanderbiest commented Aug 21, 2015

Porting @pmauduit 's addon to geOrchestra 14.12 and later (using OpenLayers' built in OSM format rather than a server side component).

It should work right now, but some more work is needed (translations, factorization ...)

The drawback of using client-side parsing of OSM data is that we miss the nice features that pmauduit had crafted on the server side (polygon detection and so on).

The good part is that it is already available for everyone.

@fvanderbiest fvanderbiest self-assigned this Aug 21, 2015

@fvanderbiest fvanderbiest added this to the 15.12 milestone Aug 21, 2015

@pmauduit

This comment has been minimized.

Show comment
Hide comment
@pmauduit

pmauduit Aug 21, 2015

Member

Thanks for the initiative ;-)

Since you are doing everything from my code or porting some other parts client-side, I call myself out of the review (LGTM anyway :P)

Member

pmauduit commented Aug 21, 2015

Thanks for the initiative ;-)

Since you are doing everything from my code or porting some other parts client-side, I call myself out of the review (LGTM anyway :P)

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Aug 21, 2015

Member

Looks better now.
Missing spanish and german translations in manifest.json

Member

fvanderbiest commented Aug 21, 2015

Looks better now.
Missing spanish and german translations in manifest.json

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Aug 21, 2015

Member

Maybe we should investigate a bit more the OSM format options (eg: areaTags).

Member

fvanderbiest commented Aug 21, 2015

Maybe we should investigate a bit more the OSM format options (eg: areaTags).

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Aug 22, 2015

Member
  • missing loading indicator
Member

fvanderbiest commented Aug 22, 2015

  • missing loading indicator
@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 22, 2015

Member
<fphg> petite idée d'amélioration : ajouter une liste de requêtes preset
<fphg> ... à prendre dans GEOR_config.js avec titre, request, style
Member

fvanderbiest commented Sep 22, 2015

<fphg> petite idée d'amélioration : ajouter une liste de requêtes preset
<fphg> ... à prendre dans GEOR_config.js avec titre, request, style
@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 22, 2015

Member

Merci @Louca2014 pour

"es": {
            "OSM data": "Datos OSM",
            "This addon allows you to display OSM data in your map": "Esta herramienta le permite mostrar datos OSM en su mapa",
            "OSM to geOrchestra": "OSM a geOrchestra",
            "Query": "Consulta",
            "Style": "Estilo",
            "Keep previously loaded features": "Conservar los objetos existentes",
            "Execute": "Ejecutar",
            "Osm2Geor_HELP_URL": "http://wiki.openstreetmap.org/wiki/Overpass_API/Language_Guide"
Member

fvanderbiest commented Sep 22, 2015

Merci @Louca2014 pour

"es": {
            "OSM data": "Datos OSM",
            "This addon allows you to display OSM data in your map": "Esta herramienta le permite mostrar datos OSM en su mapa",
            "OSM to geOrchestra": "OSM a geOrchestra",
            "Query": "Consulta",
            "Style": "Estilo",
            "Keep previously loaded features": "Conservar los objetos existentes",
            "Execute": "Ejecutar",
            "Osm2Geor_HELP_URL": "http://wiki.openstreetmap.org/wiki/Overpass_API/Language_Guide"
@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 24, 2015

Member

@jpklipfel : est-ce que CIGAL pourrait m'aider à traduire ceci en allemand ?

        "de": {
            "OSM data": "Données OSM",
            "This addon allows you to display OSM data in your map": "Cet addon vous permet d'afficher des données OSM dans votre carte",
            "OSM to geOrchestra": "OSM vers geOrchestra",
            "Query": "Requête",
            "Style": "Style",
            "Keep previously loaded features": "Conserver les objets existants",
            "Execute": "Exécuter"
        }

Merci !

Member

fvanderbiest commented Sep 24, 2015

@jpklipfel : est-ce que CIGAL pourrait m'aider à traduire ceci en allemand ?

        "de": {
            "OSM data": "Données OSM",
            "This addon allows you to display OSM data in your map": "Cet addon vous permet d'afficher des données OSM dans votre carte",
            "OSM to geOrchestra": "OSM vers geOrchestra",
            "Query": "Requête",
            "Style": "Style",
            "Keep previously loaded features": "Conserver les objets existants",
            "Execute": "Exécuter"
        }

Merci !

@jpklipfel

This comment has been minimized.

Show comment
Hide comment
@jpklipfel

jpklipfel Sep 24, 2015

Contributor

Hello,

    "de": {
        "OSM data": "OSM-Daten",
        "This addon allows you to display OSM data in your map": "Dieses Add-on ermöglicht es die OSM-Daten in Ihrer Karte anzuzeigen",
        "OSM to geOrchestra": "OSM zu geOrchestra",
        "Query": "Abfrage",
        "Style": "Style",
        "Keep previously loaded features": "Zuvor hinzugeladene Objekte beibehalten",
        "Execute": "Ausführen"
    }

Merci au SIGRS/GISOR !

Contributor

jpklipfel commented Sep 24, 2015

Hello,

    "de": {
        "OSM data": "OSM-Daten",
        "This addon allows you to display OSM data in your map": "Dieses Add-on ermöglicht es die OSM-Daten in Ihrer Karte anzuzeigen",
        "OSM to geOrchestra": "OSM zu geOrchestra",
        "Query": "Abfrage",
        "Style": "Style",
        "Keep previously loaded features": "Zuvor hinzugeladene Objekte beibehalten",
        "Execute": "Ausführen"
    }

Merci au SIGRS/GISOR !

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 24, 2015

Member

Looks better and better :-)
Thanks everyone. Releasing soon...

Member

fvanderbiest commented Sep 24, 2015

Looks better and better :-)
Thanks everyone. Releasing soon...

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 25, 2015

Member

Current status...
capture du 2015-09-25 22 09 20

Member

fvanderbiest commented Sep 25, 2015

Current status...
capture du 2015-09-25 22 09 20

@fphg

This comment has been minimized.

Show comment
Hide comment
@fphg

fphg Sep 25, 2015

Member

sweet :)

Member

fphg commented Sep 25, 2015

sweet :)

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 26, 2015

Member

Please help me provide default requests and / or styles, thanks :-)

Member

fvanderbiest commented Sep 26, 2015

Please help me provide default requests and / or styles, thanks :-)

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 26, 2015

Member

I think it's good to go, now.
Please test and report issues before I merge into 14.12. Thanks.

Member

fvanderbiest commented Sep 26, 2015

I think it's good to go, now.
Please test and report issues before I merge into 14.12. Thanks.

@fphg

This comment has been minimized.

Show comment
Hide comment
@fphg

fphg Sep 26, 2015

Member

Running on 15.06 dev.geobretagne.fr

the request list is nice and shows potential.
"label": "${_name}" is always returning "undefined". 'Undefined' should'nt be labelled.
changing to "label": "${_name}" shows some non-null labels.
"Openlayers" stylename is cryptic (orange ?)

Anyway, the default conf is just a sample, now it's up to each SDI.
Great work !

Member

fphg commented Sep 26, 2015

Running on 15.06 dev.geobretagne.fr

the request list is nice and shows potential.
"label": "${_name}" is always returning "undefined". 'Undefined' should'nt be labelled.
changing to "label": "${_name}" shows some non-null labels.
"Openlayers" stylename is cryptic (orange ?)

Anyway, the default conf is just a sample, now it's up to each SDI.
Great work !

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 27, 2015

Member

"label": "${_name}" is always returning "undefined". 'Undefined' should'nt be labelled.
changing to "label": "${_name}" shows some non-null labels.

Strange, because c8c1958 should prevent this when using "${_name}" as label.
"${name}" is the raw name, and it can be undefined, true

Member

fvanderbiest commented Sep 27, 2015

"label": "${_name}" is always returning "undefined". 'Undefined' should'nt be labelled.
changing to "label": "${_name}" shows some non-null labels.

Strange, because c8c1958 should prevent this when using "${_name}" as label.
"${name}" is the raw name, and it can be undefined, true

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 27, 2015

Member

Strange

OK, I get it.
You probably did not update GEOR_util.js, which is required to get correct labels.

Member

fvanderbiest commented Sep 27, 2015

Strange

OK, I get it.
You probably did not update GEOR_util.js, which is required to get correct labels.

fvanderbiest added a commit that referenced this pull request Sep 27, 2015

@fvanderbiest fvanderbiest merged commit faebf4f into 14.12 Sep 27, 2015

@fvanderbiest fvanderbiest deleted the osm2geor branch Sep 27, 2015

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 27, 2015

Member

Cascade merge done => now available for everyone on 14.12, 15.06 and master.

Member

fvanderbiest commented Sep 27, 2015

Cascade merge done => now available for everyone on 14.12, 15.06 and master.

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
Member

fvanderbiest commented Sep 27, 2015

@fvanderbiest fvanderbiest added the 14.12 label Sep 27, 2015

@landryb

This comment has been minimized.

Show comment
Hide comment
@landryb

landryb Sep 28, 2015

Member

area["boundary"="administrative"]["admin_level"=8]{{BBOX}}; queries administrative boundaries of level 8, but here JS blows my web browser even on a small bbox.

Member

landryb commented Sep 28, 2015

area["boundary"="administrative"]["admin_level"=8]{{BBOX}}; queries administrative boundaries of level 8, but here JS blows my web browser even on a small bbox.

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 28, 2015

Member

but here JS blows my web browser even on a small bbox.

Not surprising ... ;-)
capture du 2015-09-28 10 45 57

Member

fvanderbiest commented Sep 28, 2015

but here JS blows my web browser even on a small bbox.

Not surprising ... ;-)
capture du 2015-09-28 10 45 57

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 29, 2015

Member

Those who'd like to install this addon in their 14.12 or 15.06 instances should :

  • add the addon config in their mapfishapp's GEOR_custom.js file, see the related documentation
  • redeploy their security-proxy and mapfishapp from updated sources
Member

fvanderbiest commented Sep 29, 2015

Those who'd like to install this addon in their 14.12 or 15.06 instances should :

  • add the addon config in their mapfishapp's GEOR_custom.js file, see the related documentation
  • redeploy their security-proxy and mapfishapp from updated sources
@rafemoro

This comment has been minimized.

Show comment
Hide comment
@rafemoro

rafemoro Sep 29, 2015

Congratulations, I am now testeando, hopefully soon include GeoBolivia
captura de pantalla de 2015-09-29 12 09 24

rafemoro commented Sep 29, 2015

Congratulations, I am now testeando, hopefully soon include GeoBolivia
captura de pantalla de 2015-09-29 12 09 24

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 29, 2015

Member

Congratulations, I am now testeando, hopefully soon include GeoBolivia

Happy to hear that it will be useful to people around the globe ;-)

Member

fvanderbiest commented Sep 29, 2015

Congratulations, I am now testeando, hopefully soon include GeoBolivia

Happy to hear that it will be useful to people around the globe ;-)

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 29, 2015

Member

Those who plan to use this addon to improve their own databases must not forget that the OSM license is viral, which means that copying a single feature from the OSM database will require their own database to be redistributed under the terms of the ODBL as well.

Member

fvanderbiest commented Sep 29, 2015

Those who plan to use this addon to improve their own databases must not forget that the OSM license is viral, which means that copying a single feature from the OSM database will require their own database to be redistributed under the terms of the ODBL as well.

@fvanderbiest

This comment has been minimized.

Show comment
Hide comment
@fvanderbiest

fvanderbiest Sep 29, 2015

Member

... which does not mean that it cannot be used as a hint for missing features ...

Member

fvanderbiest commented Sep 29, 2015

... which does not mean that it cannot be used as a hint for missing features ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment