Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#28: SCM Connection #32

Merged
merged 15 commits into from Dec 19, 2022
Merged

Conversation

sparsick
Copy link
Collaborator

@sparsick sparsick commented May 29, 2021

Fix #28

@codecov-commenter
Copy link

Codecov Report

Merging #32 (1769581) into master (a47b99b) will decrease coverage by 0.67%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
- Coverage     37.95%   37.27%   -0.68%     
  Complexity       24       24              
============================================
  Files            10       10              
  Lines           166      169       +3     
  Branches          9        9              
============================================
  Hits             63       63              
- Misses           98      101       +3     
  Partials          5        5              
Impacted Files Coverage Δ
.../georgberky/maven/plugins/depsupdate/UpdateMojo.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a47b99b...1769581. Read the comment docs.

@sparsick sparsick added the feature New feature or request label Oct 3, 2022
@sparsick sparsick marked this pull request as ready for review November 15, 2022 18:22
@sparsick
Copy link
Collaborator Author

@georgberky This PR creates two new issues:

  • push option must be configurable because current default push options are gitlab specific in jgit and in Native GIt we are not any push options
  • I had to disable StrictHostKeyChecking

IMO we should create two new issues.

@sparsick sparsick marked this pull request as draft November 15, 2022 18:26
@sparsick
Copy link
Collaborator Author

Back to draft because Drone does not support DIND yet

georgberky and others added 3 commits December 19, 2022 17:47
Co-Authored-By: Sandra Parsick <sparsick@web.de>
Co-Authored-By: Sandra Parsick <sparsick@web.de>
@sparsick sparsick marked this pull request as ready for review December 19, 2022 17:03
@sparsick sparsick mentioned this pull request Dec 19, 2022
@georgberky georgberky merged commit 7af4634 into georgberky:master Dec 19, 2022
@georgberky georgberky deleted the features/scmconnection branch December 19, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set SCM Connection properties as Optional When Native Provider is chose
3 participants