From ce49da53c2422489cb0a0dbc98b7660d4778cb34 Mon Sep 17 00:00:00 2001 From: "George Y. Kussumoto" Date: Sun, 8 Jan 2017 21:20:17 -0200 Subject: [PATCH] Minor improvements on SQSProvider --- loafer/ext/aws/providers.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/loafer/ext/aws/providers.py b/loafer/ext/aws/providers.py index 9aa9934..5616946 100644 --- a/loafer/ext/aws/providers.py +++ b/loafer/ext/aws/providers.py @@ -17,16 +17,13 @@ def __init__(self, source, endpoint_url=None, use_ssl=True, options=None, loop=N self.endpoint_url = endpoint_url self.use_ssl = use_ssl self._loop = loop or asyncio.get_event_loop() - self._client = None - self._options = options + self._options = options or {} @cached_property def client(self): - if not self._client: - session = aiobotocore.get_session(loop=self._loop) - self._client = session.create_client('sqs', endpoint_url=self.endpoint_url, - use_ssl=self.use_ssl) - return self._client + session = aiobotocore.get_session(loop=self._loop) + return session.create_client('sqs', endpoint_url=self.endpoint_url, + use_ssl=self.use_ssl) async def get_queue_url(self): response = await self.client.get_queue_url(QueueName=self.source) @@ -45,9 +42,8 @@ async def fetch_messages(self): queue_url = await self.get_queue_url() logger.debug('fetching messages on {}'.format(queue_url)) - options = self._options or {} try: - response = await self.client.receive_message(QueueUrl=queue_url, **options) + response = await self.client.receive_message(QueueUrl=queue_url, **self._options) except botocore.exceptions.ClientError as exc: raise ProviderError('Error when fetching messages') from exc