New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix if BUILD_SHARED_LIBS is OFF #20

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@TimothyGu
Contributor

TimothyGu commented Aug 16, 2014

The option() disrupts toolchain files.

Fix if BUILD_SHARED_LIBS is OFF
The option() disrupts toolchain files.

Signed-off-by: Timothy Gu <timothygu99@gmail.com>
@georgmartius

This comment has been minimized.

Owner

georgmartius commented Aug 16, 2014

But shouldn't this option be ON by default. Now it would be OFF right?

@TimothyGu

This comment has been minimized.

Contributor

TimothyGu commented Aug 16, 2014

Yes. Would you like the behavior to be the new default? If so, I can omit the removal of option() in the patch.

@georgmartius

This comment has been minimized.

Owner

georgmartius commented Aug 16, 2014

Yes, I think the shared objects should be build by default. But you write that something disrupts toolchain files. What do you mean by that?

@TimothyGu

This comment has been minimized.

Contributor

TimothyGu commented Aug 16, 2014

In mxe we manage the libtype through using a cmake toolchain file which sets or clears BUILD_LIBS_SHARED. However the cmake toolchain file is applied before the option default is set, which means the so-called "initial" or "default" value overrides the user-applied setting.

@georgmartius

This comment has been minimized.

Owner

georgmartius commented Aug 16, 2014

Mh, I see. this seams a general problem, how is it solved by other projects. I want options and they should have default values.
I think that for normal usages the shared libs should be by default on. Do you see a way of achieving this?

@xantares

This comment has been minimized.

xantares commented Oct 10, 2014

-1
it was fine before

@TimothyGu

This comment has been minimized.

Contributor

TimothyGu commented Oct 11, 2014

I decided to drop the patch.

@TimothyGu TimothyGu closed this Oct 11, 2014

@trickkiste

This comment has been minimized.

trickkiste commented Sep 8, 2017

So what do I have to do, in order to compile vidstab for static linking into ffmpeg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment