Remove clone
in geometry trait implementation
#1121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.md
if knowledge of this change could be valuable to users.I struggled with this initially because I thought I had to implement
Iter
in terms ofSelf::ItemType
, which resulted in a double&&Self::ItemType
.In geoarrow-rs this resulted in a massive speedup (see geoarrow/geoarrow-rs#278 (comment)) for converting
geo
objects togeoarrow
(which is entirely implemented on top of these traits):In the short term, in geoarrow-rs this also means all algorithms that result in geometries will get faster (though this probably isn't a huge part of the overall time) because currently all algorithms are implemented by converting each geometry to
geo
, applying the operation, and converting the output vec back to geoarrow.