Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made coord fields public #4

Merged
merged 1 commit into from
Jan 21, 2020
Merged

made coord fields public #4

merged 1 commit into from
Jan 21, 2020

Conversation

bluenote10
Copy link
Member

I haven't used Rust in many years, but from what I remember the fields should be pub. Without pub fields or a Coord::new it is basically impossible to construct a Coord, right?

@Stoeoef
Copy link
Contributor

Stoeoef commented Jan 12, 2020

That's a fair point,coord is indeed not constructible and unusable at the moment.

We might be more future safe by only exposing a new function and keeping the fields private. OTOH, I don't see any scenario where exposing the fields would be harmful and would suggest to go for the PR. @frewsxcv : Any opinion on this?

@bluenote10
Copy link
Member Author

Any chance of getting this merged and released?

Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for being patient with this, your change looks good!

@frewsxcv frewsxcv merged commit 3e9fae4 into georust:master Jan 21, 2020
@bluenote10
Copy link
Member Author

Great, thanks for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants