Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm duplicate species for SO4 in aciduptake.eqn #1339

Closed
wants to merge 1 commit into from

Conversation

tsherwen
Copy link
Contributor

@tsherwen tsherwen commented Aug 5, 2022

There are currently two entries for SO4 in the aciduptake branch *.eqn KPP. This commit removes one of these.

Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple typo fix to remove a duplicate line.

@msulprizio msulprizio changed the base branch from main to dev August 10, 2022 15:53
@msulprizio msulprizio self-assigned this Aug 10, 2022
@msulprizio msulprizio added the category: Bug Something isn't working label Aug 10, 2022
@msulprizio msulprizio added this to the 14.0.1 milestone Aug 10, 2022
yantosca added a commit that referenced this pull request Aug 25, 2022
… into bugfix/aciduptake

This merge brings in the update from geoschem/geos-chem PR #1339.

We have deleted a duplicate instance of SO4 in the species list
in the KPP/aciduptake/aciduptake.eqn chemistry mechanism file.  This will
not affect any other simulations as currently the aciduptake mechanism
is a research option and not built by default.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca
Copy link
Contributor

This has been merged into the 14.0.1 development stream.

@yantosca yantosca added the topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms label Aug 25, 2022
@yantosca yantosca closed this Aug 25, 2022
@msulprizio msulprizio modified the milestones: 14.0.1, 14.0.0 Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants