Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOS-Chem diagnostics in CESM #1509

Merged
merged 7 commits into from Nov 16, 2022
Merged

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Nov 16, 2022

This pull request contains Haipeng Lin's (@jimmielin) HISTORY.rc updates for use with CESM. I added changes on top of that. It supercedes #1480 so that the update can go into 14.0.2 rather than 14.1. Here is the message from the original PR:

Hi GCST,

This is a draft PR as @lizziel is still reviewing the companion PR in CESM-GC: geoschem/CAM#11. Once the review is complete, this PR likely needs to be merged before the companion PR, so it will use the correct HISTORY.rc.

Because we will be adopting the GCHP HistoryExports component for CESM-GC, we need to write out the wildcards explicitly in HISTORY.rc similarly to GCHP.

Because not all processes in CESM-GC are handled within GEOS-Chem, the collections of processes not handled by GEOS-Chem routines, and as such diagnostics would be unavailable, are deleted from HISTORY.rc in CESM to reduce confusion. This includes drydep, wetdep, advection.

Thanks!
Haipeng

jimmielin and others added 2 commits November 16, 2022 10:29
Because we will be adopting the GCHP HistoryExports component for
CESM-GC, we need to write out the wildcards explicitly in HISTORY.rc
similarly to GCHP.

Because not all processes in CESM-GC are handled within GEOS-Chem,
the collections of processes not handled by GEOS-Chem routines,
and as such diagnostics would be unavailable, are deleted from HISTORY.rc
in CESM to reduce confusion. This includes drydep, wetdep, advection.
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel added category: Feature Request New feature or request topic: Diagnostics Related to output diagnostic data topic: CESM Related to running GEOS-Chem in CESM labels Nov 16, 2022
@lizziel lizziel added this to the 14.0.2 milestone Nov 16, 2022
@lizziel lizziel self-assigned this Nov 16, 2022
@lizziel lizziel marked this pull request as ready for review November 16, 2022 15:40
@lizziel lizziel mentioned this pull request Nov 16, 2022
run/CESM/HISTORY.rc Outdated Show resolved Hide resolved
run/CESM/HISTORY.rc Outdated Show resolved Hide resolved
run/CESM/HISTORY.rc Outdated Show resolved Hide resolved
run/CESM/HISTORY.rc Outdated Show resolved Hide resolved
@yantosca yantosca added the no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations label Nov 16, 2022
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge! Thanks @lizziel

…ents

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel merged commit 72203a9 into dev/14.0.2 Nov 16, 2022
@msulprizio msulprizio deleted the feature/geoschem_diagnostics_in_cesm branch November 28, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: CESM Related to running GEOS-Chem in CESM topic: Diagnostics Related to output diagnostic data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants