New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PULL REQUEST] Changes required for CESM2-GC #728
Conversation
(1) This allows different threads to reuse the same SpcData if it has already been initialized on this core. Previously, SpcCount was a local variable, and was thus not initialized when running Init_State_Chm after the first time. Thus, all SpcCount%n* were identically zero. Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
(1) This is required for CESM as EXTERNAL_PEDGE is defined with maximum dimension (pcols), whereas State_Met%PEDGE and State_Grid are defined with local number of columns (ncol) (2) Also update function call in GCHP interface Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
(1) This prevents multiple initialization when running on multiple MPI threads per task Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
(1) In CESM, MAM performs dry and wet deposition of its own aerosols. Some GEOS-Chem aerosols are inherited from MAM and are thus deposited using MAM's routines. Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
(1) This allows different threads to reuse the same SpcData if it has already been initialized on this core. Previously, SpcCount was a local variable, and was thus not initialized when running Init_State_Chm after the first time. Thus, all SpcCount%n* were identically zero. Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
(1) This is required for CESM as EXTERNAL_PEDGE is defined with maximum dimension (pcols), whereas State_Met%PEDGE and State_Grid are defined with local number of columns (ncol) (2) Also update function call in GCHP interface Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
(1) This prevents multiple initialization when running on multiple MPI threads per task Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
(1) In CESM, MAM performs dry and wet deposition of its own aerosols. Some GEOS-Chem aerosols are inherited from MAM and are thus deposited using MAM's routines. Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Note: Simulation start/end date, simulation type and meteorology do not matter as these are set by CAM. Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
(1) Make pointers public allow us to fill in data from HEMCO externally Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
…orm dep." This reverts commit 4ba6840.
aerosols for CESM-GC Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
(1) CESM requires its constituents to be capitalized (i.e. only with upper case characters) Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Signed-off-by: Thibaud Fritz <fritzt@mit.edu>
Thanks @fritzt. We can include these changes in the next benchmark version, GEOS-Chem 13.2.0. We're wrapping up 13.1.0 now. |
Thanks @fritzt! This passed all integration and diff tests and is ready to merge. This is a zero diff update. |
Hi @fritzt. I found an issue with your changes in commit 1abb448. Changing |
Hi @msulprizio! Feel free to revert this! This is not affecting CESM2-GC. |
Will do. Thanks for the confirmation! |
Hello!
This PR fixes some of the remaining issues that I had for CESM2-GC.
run/CESM
folder containing all the input files required for CESM2-GC (HEMCO_Config.rc
, ...)#ifdef MODEL_CESM
)Accept_External_Pedge
routine to include aState_Grid
argument. In CESM, different chunks can have different number of columns. TheEXTERNAL_PEDGE
variable is initialized with the maximum number of columns (pcols
), but the dimensions ofState_Met%PEDGE
andState_Grid
are chunk-dependent and are only defined withncol
columns.Let me know if you need anything else!
Regards,
Thibaud Fritz