New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOS-8108] fix for null namespaces with GetPropertyValue and stored queries requests #2653

Merged
merged 1 commit into from Nov 22, 2017

Conversation

Projects
None yet
2 participants
@ridethepenguin
Contributor

ridethepenguin commented Nov 21, 2017

https://osgeo-org.atlassian.net/browse/GEOS-8108

The trick of adding all the namespaces in the catalog before encoding, taking care of temporarily disabling local workspace filtering if needed, was applied also to GetPropertyValueResponse .

Test cases for GetPropertyValue requests and GetFeature requests making use of a StoredQuery were added to the test class NamespacesWfsTest, which provides a sample mapping involving two nested complex feature types in two GML flavors, 3.1 and 3.2: this allows to test both GML 3.1 and GML 3.2 output formats (where applicable).

@ridethepenguin ridethepenguin requested a review from nmco Nov 21, 2017

@bencaradocdavies

This comment has been minimized.

Member

bencaradocdavies commented Nov 22, 2017

@ridethepenguin that looks good to me. I do not know why this would cause the Travis CI build to fail in gs-restconfig. I have restarted the Travis CI build.

@ridethepenguin

This comment has been minimized.

Contributor

ridethepenguin commented Nov 22, 2017

@bencaradocdavies thanks for restarting the build, I see it's green now.

@bencaradocdavies bencaradocdavies merged commit f106b5f into geoserver:master Nov 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bencaradocdavies

This comment has been minimized.

Member

bencaradocdavies commented Nov 22, 2017

@ridethepenguin apologies for not waiting for @nmco to review (I think he is at a conference). I think the changes look fine and the test coverage is good.

@bencaradocdavies

This comment has been minimized.

Member

bencaradocdavies commented Nov 22, 2017

Online tests against postgis still work after merging. :-)

@ridethepenguin

This comment has been minimized.

Contributor

ridethepenguin commented Nov 23, 2017

@bencaradocdavies Great, thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment