Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fixed patch from #4834 to fix transparency in animated gif #595
this is actually the patch from Simone Giannecchini, with one little
I'm not aware of tests which can test this automatically, but if possible please guide me and I will try to add tests for this.
I can create a simple shapefile and url's to test this, if needed.
Hi, thanks a lot for the work.
In terms of adding a test, you should be able to extend or mimic DimensionVectorGetMapTest.testTimeListAnimated, and parse back the response to see if there are transparent pixels, or not.
Also, I see you modified two files compared to Simone's patch, so you should sign and send by mail the contribution agreement: geoserver.org/comm/assignment_agreement.pdf
@aaime sorry, I'm trying to understand how the test classes are setup, so I can check which pixels are supposed to be transparent or not.
My plan was to use available testdata to set up a local geoserver and to fire the url's from for example: https://github.com/geoserver/geoserver/blob/master/src/wms/src/test/java/org/geoserver/wms/wms_1_1_1/DimensionsVectorGetMapTest.java
But I seem not to be able to find the data which is actually used there.
I added two tests now. Please try/test/review :-)
I commented some writing to image files in the code, but I'll add the wanted images below.
I hope it is ok like this.
have just forwarded the message to firstname.lastname@example.org as questioned.
plz let me know if you need more information