GSIP 149

Kevin Smith edited this page Aug 9, 2016 · 15 revisions
Clone this wiki locally

GSIP 149 - GeoServer Styling Page Improvements

Overview

The basic idea behind this proposal is to incorporate most of the features from the CSS Styles page (part of the CSS Extensions) into the main GeoServer styling page in order to improve the main page.

Additionally, once the core styling page has incorporated these features, the CSS Styles page would be deleted from the CSS Styling extension

Proposed By

Torben Barsballe

Assigned to Release

This proposal is for GeoServer 2.10 and later.

State

  • Under Discussion
  • In Progress
  • Completed
  • Rejected
  • Deferred

Motivation

The CSS Styling page has includes a number of features that would be very usefull on the main styling page, such as a map preview. In addition, now that the main styling page supports all style formats (SLD, CSS, YSLD), it does not make much sense to have a seperate CSS Styling page.

Proposal

The style editor is effectively identical between the Style and CSS Styles page, so this will be retained as-is.

The tabbed interface from the CSS Styles page will be added at the top of the Styles page.

  • A new tab will be added for the Style configuration (Name, workspace, format, legend etc.).
  • The generated SLD tab from the CSS page will be removed. A link to the Styles endpoint will be added to replace this functionality.
  • A new tab will be added for layer associations. This will replace the link / modal window used by the CSS Styles page (Not shown on the below image).
  • The Map preview tab will be retained, but will be upgraded to use OL3 instead of OL2. The ability to set a (optional) basemap will be added. Basemaps may be limited to existing geoserver layergroups in order to fully support reprojection.
  • The Data (layer attributes) tab will be retained, although it may be renamed for clarity.
  • The CSS Reference tab will be removed. A link to the docs (generated based on the current style format) will be added to the Style configuration tab in place of this functionality.

The new page (with tabs) will look approximately like:

The CSS Style page also provides some administrative functionality for assigning styles to layers. This is still usefull, and will be incorporated somewhere on the new style page.

  • Editing style: <name> will be removed, as the ability to change the current style does not follow our UI conventions from other pages.
  • Previewing on layer: topp:state (Which allows you to change the preview layer) will be retained, and moved to both the Map abd Data (layer attributes) tabs.
  • Set style as default for current layer will be removed, and this functionality will be added as a new collum on the change layer associations table.
  • Change layer associations will be retained, but rather than a link to a popup window containing a list, the list will just be its own tab on the styles page.
  • Create a new CSS style will be removed, as it does not follow our current UI conventions for creating styles.

Backwards Compatibility

All proposed changes are limited to the GeoServer Wicket UI, so there are no backwards compatibility concerns from an API standpoint.

However, given the recent Wicket Migration, it does not seem feasible to backport these changes to earlier versions of GeoServer, even if this was desired (except perhaps GeoServer 2.9.x).

Voting

Project Steering Committee:

  • Alessio Fabiani:
  • Andrea Aime: +1
  • Ben Caradoc-Davies: +1
  • Brad Hards: +1
  • Christian Mueller: +1
  • Ian Turton: +1
  • Jody Garnett: +1
  • Jukka Rahkonen: +1
  • Kevin Smith: +1
  • Simone Giannecchini: +1

Links