Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3153 Embedded doesn't work on ie11 #3176

Merged
merged 2 commits into from Sep 4, 2018

Conversation

allyoucanmap
Copy link
Contributor

Description

Added a file where list and require polyfills.

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

What is the current behavior? (You can also link to an open issue here)
Embedded dosn't work in ie11 because missing Object.assign polyfill
error related to file react-dock/lib/Dock.js

What is the new behavior?
Embedded loads the map viewer

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
Verify use and location of StandardApp in others projects

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 80.907% when pulling 55ee89d on allyoucanmap:ie11-assign-p into 78a1458 on geosolutions-it:master.

Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, we can open an issue for the future to remove object-assign lib in favour of Object.assign.
@mbarto do you agree to add a file that includes all needed dependencies for polyfills and so on?

@mbarto
Copy link
Contributor

mbarto commented Sep 3, 2018

@offtherailz I agree

@offtherailz offtherailz merged commit 2f959b7 into geosolutions-it:master Sep 4, 2018
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this pull request Sep 4, 2018
allyoucanmap added a commit that referenced this pull request Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded doesn't work on ie11
4 participants