Skip to content
Commits on Apr 14, 2011
  1. @zwily

    don't return a deleted pseudonym for users

    Change-Id: I9706803f6002ce9ceb727c6cf7a623f84b1eb73c
    Reviewed-on: https://gerrit.instructure.com/3094
    Reviewed-by: Brian Palmer <brianp@instructure.com>
    Tested-by: Hudson <hudson@instructure.com>
    zwily committed Apr 14, 2011
  2. @codekitchen

    fix local storage with StringIO attachment uploads

    Change-Id: Ie74fe8304ef9a73dd24ccd2c303ade2646fe7828
    Reviewed-on: https://gerrit.instructure.com/3080
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: JT Olds <jt@instructure.com>
    codekitchen committed Apr 14, 2011
  3. @zwily

    don't respond to messages with an unrecognized To: address

    Change-Id: I06b4d42aa79ffdbc4fd9430e6eaddff4e668fa0e
    Reviewed-on: https://gerrit.instructure.com/3084
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Cody Cutrer <cody@instructure.com>
    zwily committed Apr 14, 2011
  4. @whitmer

    background scribd resubmission

    If a scribd submission errors out, we add a delay
    and make it a background task to resubmit the
    scribd doc.  This is important since sometimes the
    resubmission gets triggered as part of a page
    request, and it also waits a little bit before
    resubmitting to scribd in case the problem
    is something to do with their servers.
    
    Change-Id: I14e796b90bad371c8c2718fc83cd22c97d94cc96
    Reviewed-on: https://gerrit.instructure.com/3026
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Ryan Shaw <ryan@instructure.com>
    whitmer committed Apr 11, 2011
  5. @zwily

    fix capitalization in email footer

    Change-Id: I7b39c08d64553512d7f22f678d414913847a5c50
    Reviewed-on: https://gerrit.instructure.com/3077
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Zach Wily <zach@instructure.com>
    zwily committed Apr 14, 2011
  6. @zwily

    on email responses, just look up the user from the message being resp…

    …onded to
    
    Change-Id: I43514e34e49cdebb1be69cfb29f683e4e86c859b
    Reviewed-on: https://gerrit.instructure.com/3079
    Reviewed-by: Cody Cutrer <cody@instructure.com>
    Tested-by: Hudson <hudson@instructure.com>
    zwily committed Apr 14, 2011
  7. @whitmer

    migration process for moving to new kaltura instance

    This commit makes it possible to migrate media collections
    from one Kaltura instance to another.  It adds an
    old_media_id column to media_objects that can be used
    as a fallback.  It also adds a mechanism for creating bulk
    upload csv's to migrate media objects from the old
    system to the new, while catching and preserving the
    old id so that any links inside of content will still work
    even if they have the old id.
    
    refs #4083
    
    Change-Id: Ifa213fd348a50ebd7e7ac7068d8eff40b23747d1
    Reviewed-on: https://gerrit.instructure.com/2902
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: JT Olds <jt@instructure.com>
    whitmer committed Mar 30, 2011
  8. @zwily

    be sure to skip submissions for skipped assignments; fixes #4163

    Previously we were not skipping submissions for assignments that the user had
    chosen to ignore. This change also makes sure that grade is set on the
    submission as well as score. (Grade is usually set when score is, but not in
    all cases.)
    
    Also got rid of the "lookup assignment by name" fallback in the importer. This
    could cause weirdness when a teacher had a deleted assignment in the
    downloaded gradebook that they'd recreated with the same name. We are more
    strict now about matching the assignments to what's in the course.
    
    Change-Id: I980db994f5df77104a07e81c629a5800f3b40972
    Reviewed-on: https://gerrit.instructure.com/2992
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Brian Palmer <brianp@instructure.com>
    zwily committed Apr 3, 2011
Commits on Apr 13, 2011
  1. @whitmer

    assignments getting deleted on change to submission_types

    when you change the submission type for an assignment from
    discussion_topic or quiz to something else and save, it
    looks like the assignment is getting deleted.
    
    fixes #3981
    
    Change-Id: Ic9951b35afe9dc2d28eeb9a8f4ac0ff8c8bcaf13
    Reviewed-on: https://gerrit.instructure.com/2543
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: JT Olds <jt@instructure.com>
    whitmer committed Mar 7, 2011
  2. @jtolds @codekitchen

    adding link to sis csv format docs

    Change-Id: I5e4d47db4d5479d4940dc8da3fa6d7b002bfdb50
    Reviewed-on: https://gerrit.instructure.com/3071
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Brian Palmer <brianp@instructure.com>
    jtolds committed with codekitchen Apr 13, 2011
  3. @jtolds

    fixing PhusionPassenger::Utils::RewindableInput issue

    Change-Id: Ib7dda12eddce54aa6352f621ed12020bde4a9e17
    Reviewed-on: https://gerrit.instructure.com/3063
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Zach Wily <zach@instructure.com>
    Reviewed-by: Brian Palmer <brianp@instructure.com>
    jtolds committed Apr 13, 2011
  4. @zwily

    only set auto-flushing on the logger if the logger supports it

    Change-Id: I093b3c33abb5e8136fb33212a138ec11f26bd70c
    Reviewed-on: https://gerrit.instructure.com/3062
    Reviewed-by: Brian Palmer <brianp@instructure.com>
    Tested-by: Hudson <hudson@instructure.com>
    zwily committed Apr 13, 2011
  5. @ccutrer

    Soup up grade_summary. Closes #3863.

     * Include rubric_assessments inline, rather than linking to submission page
     * Add link to "Show All Details", expands all rubric_assessments and comments sections
    
    Change-Id: I93065908fa181a337a6497d5e3142324cfed6479
    Reviewed-on: https://gerrit.instructure.com/3036
    Reviewed-by: Brian Whitmer <brian@instructure.com>
    Tested-by: Hudson <hudson@instructure.com>
    ccutrer committed Apr 12, 2011
Commits on Apr 12, 2011
  1. @jtolds

    renaming final_grade to final_score in relevant places. adding comput…

    …ed_final_grade
    
    Change-Id: I09cfecc6ec075b1b45e872a6a1f2efa7e4bd63b9
    Reviewed-on: https://gerrit.instructure.com/3034
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Brian Whitmer <brian@instructure.com>
    jtolds committed Apr 12, 2011
  2. @marksuman

    added grade_matches_current_submission to submission api response

    fixes #4240
    
    Change-Id: I3e6b6e0406f815fb50972bd606794116907ac848
    Reviewed-on: https://gerrit.instructure.com/3033
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Brian Palmer <brianp@instructure.com>
    marksuman committed Apr 12, 2011
  3. @jtolds

    disabling gradebook xml output instead of just failing

    Change-Id: I4d8103c64210a79246264a5a3b66a54ed6da1e0a
    Reviewed-on: https://gerrit.instructure.com/3009
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
    Reviewed-by: Brian Whitmer <brian@instructure.com>
    jtolds committed Apr 8, 2011
  4. @codekitchen @marksuman

    don't depend on Enrollment#type in the courses api, fixes #4244

    I'm seeing very strange behavior where the return type of this method
    changes depending on what is loaded at the time.
    
    Change-Id: I2756a61d5ed2c4d1b3257c72bea82c5d5a85a74c
    Reviewed-on: https://gerrit.instructure.com/3028
    Tested-by: Hudson <hudson@instructure.com>
    Tested-by: Mark Suman <marks@instructure.com>
    Reviewed-by: Mark Suman <marks@instructure.com>
    codekitchen committed with marksuman Apr 12, 2011
Commits on Apr 11, 2011
  1. @codekitchen

    don't destroy the quiz_submission in take_quiz, fixes #4243

    This wasn't strictly necessary to make quiz previews work, and there was
    a race condition where calling this action twice quickly could result in
    the quiz submission being destroyed and the user taking a quiz with no
    submission created.
    
    Change-Id: I8e55d988030daebf2bfc85fb660317d16a6988e5
    Reviewed-on: https://gerrit.instructure.com/3024
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Brian Whitmer <brian@instructure.com>
    codekitchen committed Apr 11, 2011
  2. @ccutrer

    Don't use AJAX to delete a topic from its own page.

    Well, not quite so obviously, anyway (Rails is generating some
    JavaScript and a form behind the scenes).  Anyhow, doing it this way,
    the controller renders html and a proper redirect, and the browser
    respects it.  Fixes #4070.
    
    Change-Id: I5477a12f746f4335202f7dd628f65da531038e23
    Reviewed-on: https://gerrit.instructure.com/3022
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Brian Whitmer <brian@instructure.com>
    ccutrer committed Apr 11, 2011
  3. @ccutrer

    Add modules to links list in wiki sidebar. Closes #3824.

     * Add modules to wiki sidebar
     * Fix redirect from courses/:id/modules/:module_id to courses/:id/modules#module_:module_id, rather than just courses/:id/modules
     * Auto-expand the specified module when you access modules/#module_:module_id
    
    Change-Id: Iaa2ab30dc462fec753fe67928fb101212cff440a
    Reviewed-on: https://gerrit.instructure.com/3021
    Reviewed-by: Brian Whitmer <brian@instructure.com>
    Tested-by: Hudson <hudson@instructure.com>
    ccutrer committed Apr 11, 2011
  4. @ccutrer

    Fix updating observer stats from AJAX. Fixes #3020.

    Change-Id: I62f117bf69b4651115db82cf865ef9da400ec0e1
    Reviewed-on: https://gerrit.instructure.com/3014
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Brian Whitmer <brian@instructure.com>
    ccutrer committed Apr 11, 2011
  5. @codekitchen

    fix grade calculations if an assignment group has 0 points possible

    This was causing all students in the course to have final grades of null
    (NaN).
    
    Change-Id: I2bc268926579ce8c129a8c997f683a9e9097bffc
    Reviewed-on: https://gerrit.instructure.com/3016
    Reviewed-by: Brian Palmer <brianp@instructure.com>
    Tested-by: Brian Palmer <brianp@instructure.com>
    codekitchen committed Apr 11, 2011
  6. @whitmer

    add sis id to UI for courses, sections, pseudonyms

    refs #4231
    
    Change-Id: I243de9ee8efb2ef6609dca99a9b38bc2200cb573
    Reviewed-on: https://gerrit.instructure.com/3011
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
    whitmer committed Apr 8, 2011
  7. @ryankshaw

    wait to init wikiSidbar files and images tabs till clicked

    this just fixes part of the problem, but it is still
    super slow to init if there are a lot of files. step
    2 will be to really make it faster
    
    fixes #4158
    
    Change-Id: Ic26ccb3d22bf28f8c70c666ddcb0eb8e0c9912fb
    Reviewed-on: https://gerrit.instructure.com/3006
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
    ryankshaw committed Apr 8, 2011
  8. @ryankshaw

    don't assume i'm editing a student user, fixes #3918

    Change-Id: I51fcb9ab73f8686609ae010ab64bda61536a65c8
    Reviewed-on: https://gerrit.instructure.com/3003
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
    ryankshaw committed Apr 8, 2011
  9. @ryankshaw

    resize speedgrader on iThing/android orientationChange

    cause it orientationChange does not fire the
    resize event handler
    
    Change-Id: Ia370cc030309c3589f9070dbcc8c3a3ba44d32b4
    Reviewed-on: https://gerrit.instructure.com/2998
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
    ryankshaw committed Apr 8, 2011
  10. @ryankshaw

    fix capitalization in speedgrader

    Change-Id: I373b37f4871b0b48106c41d81c661a91c10042ef
    Reviewed-on: https://gerrit.instructure.com/3002
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
    ryankshaw committed Apr 8, 2011
  11. @bracken

    added index page for external course migrations

    closes #4230
    
    Change-Id: Ibc550f1fc2b5fb5a0498982d676e98848530cab2
    Reviewed-on: https://gerrit.instructure.com/3013
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Brian Palmer <brianp@instructure.com>
    bracken committed Apr 11, 2011
Commits on Apr 9, 2011
  1. @zwily

    gradebook importer: handle "Points Possible" row being anywhere; #fix…

    …ed #4162
    
    Also added an explicit parse! method and made the processing of the CSV single
    pass.
    
    Change-Id: I0fdfefa5bae1c864d35da1c7975aa7691770a3e2
    Reviewed-on: https://gerrit.instructure.com/2991
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Brian Palmer <brianp@instructure.com>
    zwily committed Apr 3, 2011
Commits on Apr 8, 2011
  1. @jtolds

    sis import api

    Change-Id: Ica7fa02758e5e7ad32c878951aff8b115685ac82
    Reviewed-on: https://gerrit.instructure.com/2960
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Brian Palmer <brianp@instructure.com>
    jtolds committed Apr 5, 2011
  2. @codekitchen

    remove rack bug patch, it's been fixed in rack 1.1.2

    Change-Id: I2bb16df697738a00fde6fa6bb61f79e72fc4d5d3
    Reviewed-on: https://gerrit.instructure.com/3001
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: JT Olds <jt@instructure.com>
    codekitchen committed Apr 8, 2011
  3. @ccutrer

    Delegate to CAS for auth. Closes #4130

    Change-Id: I6bd3ef11314f75dd14b2fa9d835ecc40e43b5f3b
    Reviewed-on: https://gerrit.instructure.com/2994
    Tested-by: Hudson <hudson@instructure.com>
    Reviewed-by: Brian Palmer <brianp@instructure.com>
    ccutrer committed Apr 7, 2011
  4. @codekitchen

    api call for getting course sections, optionally with students

    refs #4156
    
    Change-Id: I8d7da2073b6063e14727c7faa6ba90e1809efa81
    Reviewed-on: https://gerrit.instructure.com/3004
    Reviewed-by: Brian Whitmer <brian@instructure.com>
    Tested-by: Hudson <hudson@instructure.com>
    codekitchen committed Apr 8, 2011
Commits on Apr 7, 2011
  1. @codekitchen

    fix the mass assignment error raising option

    Change-Id: Idc527a3d845f912fcbef56d336b5326e30c7964a
    Reviewed-on: https://gerrit.instructure.com/2993
    Reviewed-by: Brian Palmer <brianp@instructure.com>
    Tested-by: Hudson <hudson@instructure.com>
    codekitchen committed Apr 6, 2011
  2. @codekitchen

    improve js htmlEscape performance and add htmlEscapeValues helper

    Change-Id: I5c03572e9fe9b03b917ea70ec9e694362927d3dc
    Reviewed-on: https://gerrit.instructure.com/2989
    Reviewed-by: Brian Palmer <brianp@instructure.com>
    Tested-by: Hudson <hudson@instructure.com>
    codekitchen committed Apr 7, 2011
Something went wrong with that request. Please try again.